The big thing is that the original code was reverse engineered and EXCEPT for the intentional bugfixes and QoL improvements everything else is meant to be kept 100% compatible. Reverse-engineered code very rarely looks as nice as it was originally written, and the "100% compatibility aside from minor deviations" aspect means they'll be more reluctant to refactor anything that's NOT part of said deviations. Considering the type of herculean effort this was, I don't really expect it to look nice lol. (And "what's data vs what's not data" might legit be some janky Blizzard logic we don't know about.)
I'm not sure I get why you're talking the way you are, as though this is the original source code. Just because they had debug info to work off of doesn't mean it's 100% 1:1 the same as original. It's still just a decompilation project. I'd have to find the copy they were working from, but I doubt that the original code was actually written in C++ or at least not entirely in it even if any was. I'd bet good money, given the time period, that it was likely written mostly in C with some bits in assembly and if any C++ was used, it was likely just for the interface. The thing I really wonder, is did Blizzard save the original source code or is it lost to time leaving us with decompilation as the only option.
Most production code in commercials videogames are garbage (mine included!) , but it's often because of time constraints. You can't afford to gamble with the failure of the whole project and go refactoring every 3 months. Of course, there are a few rare exceptions where programmers excel at their best, like Mr. John Carmack.
as a software dev you should probably avoid making disparaging remarks about autism. you're basically alienating at minimum 50% of your co-workers/youtube audience.
*Thumbnail and title is partial clickbait.* 1. Diablo was written in C not C++. 2. The source you are looking at is NOT the original Diablo Source Code but is the *reverse engineered* code. The title is mis-leading. 3. Where is the link to Sourcetrail in the description? 4. Sourcetrail is sadly abandoned.
The big thing is that the original code was reverse engineered and EXCEPT for the intentional bugfixes and QoL improvements everything else is meant to be kept 100% compatible. Reverse-engineered code very rarely looks as nice as it was originally written, and the "100% compatibility aside from minor deviations" aspect means they'll be more reluctant to refactor anything that's NOT part of said deviations.
Considering the type of herculean effort this was, I don't really expect it to look nice lol. (And "what's data vs what's not data" might legit be some janky Blizzard logic we don't know about.)
I'm not sure I get why you're talking the way you are, as though this is the original source code. Just because they had debug info to work off of doesn't mean it's 100% 1:1 the same as original. It's still just a decompilation project. I'd have to find the copy they were working from, but I doubt that the original code was actually written in C++ or at least not entirely in it even if any was. I'd bet good money, given the time period, that it was likely written mostly in C with some bits in assembly and if any C++ was used, it was likely just for the interface.
The thing I really wonder, is did Blizzard save the original source code or is it lost to time leaving us with decompilation as the only option.
Great video as always. Are you using the original Sourcetrail or a fork?
Most production code in commercials videogames are garbage (mine included!) , but it's often because of time constraints. You can't afford to gamble with the failure of the whole project and go refactoring every 3 months. Of course, there are a few rare exceptions where programmers excel at their best, like Mr. John Carmack.
3:19 What is this tool?
Sourcetrail
@@phonomorgue.1372 Thanks!
Saw this, but thought it was the name of the project.
it's literally in the titlebar
@@phonomorgue.1372 Thanks!
@@user-93fekod1o I know! I thought it's the name of the project.
I still have my copies of the original Diablo 1 for both Windows PC and for PS1.
as a software dev you should probably avoid making disparaging remarks about autism. you're basically alienating at minimum 50% of your co-workers/youtube audience.
Love the love for low GDP bros
bro are you hungarian?
it does not run? will be nice to run it and debug it
I am an avid Diablo Autism Pro player dude... wth
*Thumbnail and title is partial clickbait.*
1. Diablo was written in C not C++.
2. The source you are looking at is NOT the original Diablo Source Code but is the *reverse engineered* code. The title is mis-leading.
3. Where is the link to Sourcetrail in the description?
4. Sourcetrail is sadly abandoned.