Junior Code Review: Laravel Routes, Middleware, Validation and more

แชร์
ฝัง
  • เผยแพร่เมื่อ 26 พ.ย. 2024

ความคิดเห็น • 419

  • @mathiasdesouza
    @mathiasdesouza 3 ปีที่แล้ว +405

    "Juniors don't be afraid to show your code. Seniors don't attack the juniors that the code is bad. We all start somewhere."

    • @JimOHalloran
      @JimOHalloran 3 ปีที่แล้ว +63

      So much this... I've been doing Software Dev for 26 years, PHP for 16 years, and Laravel for the last 2.5, and I learned something from this video. So I'd also add "Seniors, don't assume you know everything, and your way is the only way."

    • @Towzlie
      @Towzlie 3 ปีที่แล้ว +4

      @@JimOHalloran Every day there is new oppurtunities to learn things, we shoudn't feel ashamed to do so !

    • @ryanbeatbox
      @ryanbeatbox 2 ปีที่แล้ว +3

      Absolutely, thankfully my team lead adopts this mentality as well. Such a good quality to have in leadership and development in general.

  • @EsronDtamar
    @EsronDtamar 3 ปีที่แล้ว +55

    I liked the video format. And today I noticed that I'm not a junior anymore.

  • @DuilioPalacios
    @DuilioPalacios 3 ปีที่แล้ว +310

    The delete action using "GET" instead of "DELETE" might expose the user to CSRF attacks. That one should be changed for security. (I hope this observation can be useful for someone).

    • @themostnonchalant
      @themostnonchalant 3 ปีที่แล้ว +1

      buen dato , maestro.

    • @digitalminister5687
      @digitalminister5687 3 ปีที่แล้ว +6

      3:54 he mentioned it

    • @duiliopalacios1777
      @duiliopalacios1777 3 ปีที่แล้ว +7

      ​@@digitalminister5687 Yes, I know, I just wanted to point out the potential security issue, that's all :) I also record videos and it's challenging if not impossible to cover everything in one video no matter the length.

    • @JohnSmith-zl8rz
      @JohnSmith-zl8rz 3 ปีที่แล้ว

      styde needs updated videos on laravel 8 ;)

    • @DuilioPalacios
      @DuilioPalacios 3 ปีที่แล้ว

      John Smith what does that have to do with this video? And FYI I do have tons of videos in L8, just not in my TH-cam channel.

  • @ShekenZZZ
    @ShekenZZZ 3 ปีที่แล้ว +15

    Yes ! Please ! More code reviews videos ! As a junior I can't state how valuable this is. Thanks for everything !

  • @gyohza
    @gyohza 3 ปีที่แล้ว +47

    Omfg. This is like those "very satisfactory" videos with people slicing colored clay, but with coding.
    Such a rewarding feeling to watch.

  • @rikiamaru
    @rikiamaru 3 ปีที่แล้ว +3

    i agree with you on this statement
    "as junior dont be afraid to make mistake (but take responsibilty on that)"
    "as senior dont attack your junior (we have to start somewhere right)"
    huge respect to you!!

  • @11r3start11
    @11r3start11 3 ปีที่แล้ว +4

    Im experienced web developer, but a c# one. Have no idea why this video appears in my recommendation, but it's ASWESOME.
    For me It was a good overview of PHP/Laravel development). Without any experience I understood 100% of it! Thanks.

  • @justnothing7822
    @justnothing7822 3 ปีที่แล้ว +1

    Your one video > Tones of Learn laravel from strach for Inermediates.Thank you Sir, have a better life everyday.

  • @tarangpanchal4424
    @tarangpanchal4424 3 ปีที่แล้ว +26

    This means a lot of helpful to jr. developers to learn.
    I have seen many videos. many of video creators Assumes that you were aware about the mistakes that users do. but actually the fresher or junior developer wasn't aware of that. *And this is really fantastic video to identify mistakes and correct them*.

  • @gdog6036
    @gdog6036 3 ปีที่แล้ว +6

    The command in PHPStorm to highlight the next occurrence of a word is Ctrl+G on Mac and Alt-J on windows. On vscode it’s ctrl+D. Rather than moving the mouse and highlighting line by line
    Great content!

  • @SunilKumawatbfcj
    @SunilKumawatbfcj 3 ปีที่แล้ว +5

    Hello sir
    You are the most humble and kind person in the region. You always appreciate others for working hard instead of dominating them for mistakes, and helping them grow each time. I think your contribution to this growth of laravel is remarkable.
    Help is only help, whatever form it may be given, and I am grateful for your efforts and love.

  • @chaosthelegend6338
    @chaosthelegend6338 3 ปีที่แล้ว +2

    I've never written a line in PHP but still watched till the end, you never know when you gonna need this.
    Great review, very satisfactory.

  • @nagaindra2323
    @nagaindra2323 3 ปีที่แล้ว +1

    I have completed my last project fully with query builder only. This video help me to under stand the standard of code. Thank you so much sir. You videos help me lot

  • @SmailPeche
    @SmailPeche 3 ปีที่แล้ว +4

    after watching this video i’am not a junior developer anymore 😁 , more videos like this sir. this is awesome, thank you povilas ❤️

  • @udaranayana8305
    @udaranayana8305 3 ปีที่แล้ว +2

    after 7 months of coding in laravel I finally got a hang of its basics... but this video shows me I just scraped the tip of the iceberg...

  • @randomguy5922
    @randomguy5922 3 ปีที่แล้ว +2

    Very nice sir, most of the tutorials on net only deals with beginners things, ie how to start or more advance things, but you literally deal with minor problems which developers actually face, while developing something. I highly respect you for your efforts.

  • @camilorojas3261
    @camilorojas3261 2 ปีที่แล้ว +3

    Eres grande amigo. No porque sepas mucho, sino por darte el tiempo de ayudar a los que saben menos. Saludos desde Chile.

  • @0xshashwat
    @0xshashwat 3 ปีที่แล้ว +6

    That $request->validated() and $fillable combination was on another level. Got to learn something new 😄

    • @0xshashwat
      @0xshashwat 2 ปีที่แล้ว +1

      @@mbparvezme Validation messages can be set in the Request Class created using " artisan make:request" command. Laravel will take care of the rest. And for the frontend you do everything same as before.
      Also check out the laravel documentation on "The Basic > Request" section it explains it beautifully. You can also use custom Rules inside the request class instead of if statements in the controller. 😉

    • @mbparvezme
      @mbparvezme 2 ปีที่แล้ว +1

      ​@@0xshashwat Thank you for your reply. It was my fault. I just forgot to include the "Accept: application/json" header in the request. That is why it send me a response with a redirect (back). But with the appropriate header, I got the error message.

  • @muhammadhashiranwaar3239
    @muhammadhashiranwaar3239 3 ปีที่แล้ว +1

    i just watched till 1:13 and i start loving you.... This is how juniors shud be treated... Love You Sir.

  • @resin01
    @resin01 3 ปีที่แล้ว +4

    Great video. As for multi-line edit. Just double tap ctrl, and use arrow down to select all lines. Hit "End" to get the cursor to the same location on each line. Now remove the middleware in one go.

  • @junaidahmad5783
    @junaidahmad5783 3 ปีที่แล้ว +8

    Amazing concept! Please do as many videos as you can easily. This is great content. Keep up the awesome work. 👍👍👍

  • @altynbekmamasadykov4526
    @altynbekmamasadykov4526 3 ปีที่แล้ว +1

    Thanks for your videos Povilas, I am also beginner laravel Developer, i'm your fan, your videos are very helpful. When I start earning money i will obviously buy your " eloquent course"

  • @tlita93
    @tlita93 3 ปีที่แล้ว +5

    Such a phenomenal idea for the video. This what I was looking for back when I started just a year ago. I always had a feeling that new/beginner developers want to see what a real application looks like, how every part of it looks like, not just some examples and basic principles. Or even see other beginners how they code and it all looks like. So interesting. I will admitted, I do have some mistakes in common with the "author" of the code you reviewed. You should keep doing videos like this, it's really useful in terms of improving and seeing that we all actually make common mistakes, I'm no different than many other guys who started. It's a normal learning process and we shouldn't be ashamed of our silly, but important mistakes.
    Really grate video sir. 🙂
    Cheers

  • @nclsv
    @nclsv 3 ปีที่แล้ว +1

    Well then.. This 'refactoring' went so fast, I felt bad I couldn't follow everything. Time to brush up on my Laravel skills again.
    Quality video by the way. THIS is how juniors improve and learn different code styles and refactoring.

  • @ChupachuGames
    @ChupachuGames 3 ปีที่แล้ว +11

    Another note: if you're looking to refactor your routes, please take the time to make some quick feature tests that hit your routes so you can test when you change anything if something breaks and follow the errors to refactor it correctly.

  • @redward4383
    @redward4383 3 ปีที่แล้ว +3

    Awesome video, happy to see that I'm doing at least some of the things right, but even happier to see what is expected from me to write a better code in laravel.

  • @Ivoryke
    @Ivoryke 2 ปีที่แล้ว +2

    I really enjoyed and learned watching this one as a junior programmer!

  • @KJARYA
    @KJARYA 3 ปีที่แล้ว +2

    Please make this into a more regular series, very helpful! Thank you.

  • @richt222
    @richt222 3 ปีที่แล้ว +2

    Love code reviews like this! Please do more. It's a great way to learn. Thanks!

  • @yuriysemenikhin302
    @yuriysemenikhin302 3 ปีที่แล้ว +5

    I haven't done Laravel in years, but it was still interesting to watch :-)

  • @LaravelDaily
    @LaravelDaily  2 ปีที่แล้ว +2

    Liked this video? I have many more: subscribe to my 30+ Laravel courses laraveldaily.com/courses

  • @sheykhsaiful3014
    @sheykhsaiful3014 3 ปีที่แล้ว +1

    It helps us a lot as a junior Dev. please keep Reviewing .

  • @vicsystems
    @vicsystems 3 ปีที่แล้ว +1

    You really boost the morale for LARAVEL for all junior devs.

  •  3 ปีที่แล้ว +1

    This video format is great for the channel as the comment/view ratio it gets. Some stuff is obvious but other is just awesome. Keep this series coming along.

  • @nbarshain
    @nbarshain 3 ปีที่แล้ว

    Extremely helpful!! I started coding in Laravel a few months ago, and while I know how to get things done, this helped me learn how to do them the right way.
    Thank you!

  • @chrismellor7027
    @chrismellor7027 3 ปีที่แล้ว +8

    Cool video concept. Definitely do more of these as they’re interesting. I learnt a few things too 🥳

  • @codeology1
    @codeology1 3 ปีที่แล้ว +17

    Thanks , boss these kind of videos have great tricks... we need more and more

  • @SlimAndCherryTravel
    @SlimAndCherryTravel 3 ปีที่แล้ว

    This is really great, thank you. It's embarrassing to me that you probably just wrote more code in 20mins than I wrote all day today.

  • @sharjeeljan
    @sharjeeljan 3 ปีที่แล้ว +1

    Loved your disclaimers!! Great video! Thanks for sharing. I'm also a junior developer and learning a lot from your videos.

  • @JouvaMoufette
    @JouvaMoufette 3 ปีที่แล้ว +4

    Pretty good review. Only thing I would have said more explicitly is that Material:all() returns a collection, so the where is using PHP code to do its job. It may not be as obvious to the junior that the all() sets up the query AND fetches, where as the where function of the Eloquent model is simply utilizing a query builder and get does the fetch.
    The confusion mostly stemming from the collision of some function names in collections vs query builder for eloquent.

  • @zomgpro
    @zomgpro 3 ปีที่แล้ว +2

    Great video, love the format. Never knew about the eloquent "when" method. Good way to plug gaps in your knowledge

  • @ghostinplainsight4803
    @ghostinplainsight4803 3 ปีที่แล้ว

    Refactoring is like ointment for my soul. I don't even use php but this is such a great idea for youtube content.

  • @CoderGeek-u6m
    @CoderGeek-u6m 5 หลายเดือนก่อน

    I am new to Laravel and some of these things are how I coding with Laravel, some are new and I'm excited to get more.

  • @gaelduval8410
    @gaelduval8410 3 ปีที่แล้ว +3

    This chanel is gold... Great video, as always 🔥
    For this code review, I would also go for constants, instead of hardcoding Roles ID everywhere. Like ROLE_MEISTER = 0, and so on. Should make the code way more readable.

  • @IvanIvanov-qx5oz
    @IvanIvanov-qx5oz 3 ปีที่แล้ว +11

    I don't even know what the heck Laravel is, but that is a neat video format.

    • @vicsystems
      @vicsystems 3 ปีที่แล้ว

      🥺

    • @patrick-dev
      @patrick-dev 3 ปีที่แล้ว +1

      As a web developer in 2021, If you really don't know what Laravel is, you have a problem buddy!

  • @invadervim9037
    @invadervim9037 3 ปีที่แล้ว +2

    If a resource route was used you might also run into the issue of not all the routes expected being present, which very well might be intentional as you might not need all of them.
    They are; index, create, store, show, edit, update and destroy. If any are not needed you can chain the "only" or "except" methods when defining the route:
    Route::resource('photos', PhotoController::class)->only([
    'index', 'show'
    ]);
    or
    Route::resource('photos', PhotoController::class)->except([
    'create', 'store', 'update', 'destroy'
    ]);
    respectively.
    If a resource route is defined and all expected methods are not accounted for then artisan will throw an error.
    This is a great vid, just hoping to help out too if i can.

  • @DasBeatz
    @DasBeatz 3 ปีที่แล้ว +1

    Thank you this was awesome! As someone just refreshing their Laravel knowledge I learned so much

  • @vsaliyy
    @vsaliyy 3 ปีที่แล้ว +2

    really incredible video quality, learning from your lessons constantly. At work, I recommend your videos to colleagues. Thank you for such quality content!
    hello from Russia, city of Stavropol: 3

  • @guilhermemoraes4055
    @guilhermemoraes4055 3 ปีที่แล้ว

    Please make more videos like this!
    I loved to check what I am doing wrong and how to fix it and make it a better code !

  • @celebritydev1
    @celebritydev1 3 ปีที่แล้ว +1

    Wish I could like this video 10x. What a great tutorial

  • @rtpHarry
    @rtpHarry 3 ปีที่แล้ว

    Wow, I don't even code in Laravel but I couldn't stop watching. I wish there was something like this for code in Ionic, Angular, Vue or Firebase.

  • @debjit21
    @debjit21 3 ปีที่แล้ว +1

    We need more this type of videos. Thank you.

  • @QueeeeenZ
    @QueeeeenZ 3 ปีที่แล้ว +13

    Can you please make more refactoring videos like this? please!! It was soo good!

  • @ah-rasel
    @ah-rasel 3 ปีที่แล้ว +1

    I was just checking about Today's video 5 minutes ago 😁. Now here it is. Thank you Povilas.

    • @LaravelDaily
      @LaravelDaily  3 ปีที่แล้ว +2

      Yeah, this one took longer time to produce than I expected. Started with idea that "I'll just give a few tips in 5 minutes", and published this video 4 hours later :)

    • @bilawalshah7700
      @bilawalshah7700 3 ปีที่แล้ว

      Laravel daily sir, it help us alot because we are junior

  • @cxian
    @cxian 3 ปีที่แล้ว +1

    yes please do more refactoring session. Thank you!

  • @nftsparatodos1274
    @nftsparatodos1274 3 ปีที่แล้ว +1

    Nice video and so many tricks and advises in just 20 minutes. Thanks

  • @VadimBesedin
    @VadimBesedin 3 ปีที่แล้ว +1

    In PHP Storm you can use "Alt+J" to select next occurrences of the selected code or use "CTRL+Shift+Alt+J" to select ALL occurrences of the selected code.

  • @agungyudhaberliantara5561
    @agungyudhaberliantara5561 3 ปีที่แล้ว +1

    Best and crystal clear tutorial, thanks a lot 🙏

  • @chiagozieokafor5512
    @chiagozieokafor5512 ปีที่แล้ว +1

    Thanks alot Sir
    This video is just so golden for me
    Will sure watch more of this kind of your videos 🔥🔥🔥

  • @rajaasyraf25
    @rajaasyraf25 3 ปีที่แล้ว +1

    Thank you for the video. We need more like this. Keep it up!

  • @RuwanBandaraUT
    @RuwanBandaraUT 3 ปีที่แล้ว +1

    Thank you so much.. You are doing great things for beginners... Keep it up

  • @nawt12
    @nawt12 3 ปีที่แล้ว

    Hope this series got more video. very helpful for all. thanks a lot.

  • @frnkquito
    @frnkquito 3 ปีที่แล้ว +1

    Awesome video, perfectly explained, easy to understand, high value tips

  • @stevendiaz7374
    @stevendiaz7374 3 ปีที่แล้ว

    Nice video, very helpful for junior laravel devs
    Details that can simplify your life a lot!

  • @rohannnsingh84
    @rohannnsingh84 3 ปีที่แล้ว

    very very helpful sir you help me very much in laravel as i am also a laravel developer . Really thanks for your knowledgeful videos and keep ahead sir
    one more time thank you very much

  • @codingdunia
    @codingdunia 3 ปีที่แล้ว

    Keep it up sir. I always wait for your videos. I learnt more things in laravel.

  • @apriljoyaltiche3298
    @apriljoyaltiche3298 3 ปีที่แล้ว +1

    More of this, please! I am just starting in the laravel world :D

  • @ehabtalaat7592
    @ehabtalaat7592 3 ปีที่แล้ว +1

    we need more videos like this .thank you for this video

  • @raulrozza
    @raulrozza 3 ปีที่แล้ว

    I don't even code on PHP but I enjoyed the video, mostly for the lessons on organization and cleaner code.

  • @ollimac73
    @ollimac73 3 ปีที่แล้ว

    Great video, need more of this unique learning, particularly useful for any dev level. Amazing advice to junior and senior at the video introduction. 👏

  • @coolcha
    @coolcha 3 ปีที่แล้ว

    Please create more videos like this. This is so helpful.

  • @sadiarahman467
    @sadiarahman467 3 ปีที่แล้ว

    Thanks a lot . Please , make more video like this. It's very educative.

  • @georgebalan8452
    @georgebalan8452 3 ปีที่แล้ว

    This was really great, had to pause a lot to think... :). Really useful to see.

  • @sarder2008
    @sarder2008 3 ปีที่แล้ว +4

    I just learned how to use in_array, thank you very much :)

  • @gravitygear786
    @gravitygear786 2 ปีที่แล้ว

    the "store" method review i like the most

  • @rehabragab5937
    @rehabragab5937 3 ปีที่แล้ว +1

    Great video,we need more videos like this

  • @collincod4811
    @collincod4811 3 ปีที่แล้ว +1

    Great Video. I would love to watch more videos like this.

  •  3 ปีที่แล้ว +4

    I think generally you learn more from just reading the documentation (for a junior dev). And secondly just debug through the framework code to understand it better and learn how to extend it to your advantage to reduce even more boilerplate code.
    Its a good quality video though and thanks for the timeline.

  • @cethartest469
    @cethartest469 3 ปีที่แล้ว +2

    thx povilas, really awesome, we want more and more videos like this videoo

  • @klerfe85
    @klerfe85 3 ปีที่แล้ว +1

    Awesome! Really really great idea for video. Practical examples...

  • @zuhrulanam5971
    @zuhrulanam5971 2 ปีที่แล้ว

    Very cool how you give tutorial, thanks for the video man!

  • @rahafmoute4781
    @rahafmoute4781 9 หลายเดือนก่อน

    big thanks for you , you are the best in youtube truly

  • @username8586
    @username8586 3 ปีที่แล้ว

    You helped me alot with the $requests... I did it the same way as you mentioned but i left it inside the function what felt tottaly wrong and now i know why i had this feeling all the time

  • @RindiBudiaramdhan040490
    @RindiBudiaramdhan040490 3 ปีที่แล้ว +1

    need more like this. Code Review. Thanks for this share

  • @ajzack983
    @ajzack983 ปีที่แล้ว

    I love these , I hope you still make them

    • @LaravelDaily
      @LaravelDaily  ปีที่แล้ว

      I've made a lot of them, until I started repeating myself. See the Playlists of the channel, there should be one with reviews

  • @vitouvitou5269
    @vitouvitou5269 3 ปีที่แล้ว +1

    Thank you teacher .. please do this more

  • @Nemnes
    @Nemnes 3 ปีที่แล้ว

    useful, its always nice to watch videos like that one

  • @Claudio_Pereira
    @Claudio_Pereira 3 ปีที่แล้ว +1

    Povilas, another great video. I can't get enough of praising and thanking him for his work. And I think your guidelines are not just for juniors! Congratulations!

  • @mibrahim4245
    @mibrahim4245 2 ปีที่แล้ว

    simply, LEGEND !
    Thanks, I learned a lot ...

  • @dumdcode3845
    @dumdcode3845 ปีที่แล้ว

    This tutorial is very helpful!
    Thank you so much!

  • @azabudskyi
    @azabudskyi 3 ปีที่แล้ว +1

    Thanks. It was very helpful. A lot of tips that I think about every time when write code like "How to do in this situation" or "How it should be in correct way"?

  • @ahmedbreeka4379
    @ahmedbreeka4379 3 ปีที่แล้ว

    wow , it's amazing , thank you very much , I got a lot of information in this video

  • @eyadbereh
    @eyadbereh 2 ปีที่แล้ว

    At 9:30, i can see that the migration contains insertion operations
    I suggest moving those to a specific seeder class (e.g. RolesTableSeeder), because a migration isn't meant to seed database

  • @GergelyCsermely
    @GergelyCsermely 3 ปีที่แล้ว

    Thank You. Very good tips for beginners. I learn daily really :)

  • @ricko13
    @ricko13 3 ปีที่แล้ว

    Bravo! what a great video, I've learned a lot, thank you Sir, keep it going.

  • @adamkonecnycz
    @adamkonecnycz 3 ปีที่แล้ว +2

    This is very helpful. Maybe it can be new video series...

  • @yashpatel7291
    @yashpatel7291 3 ปีที่แล้ว +1

    You are doing nice work in this video. I like it

  • @eleazarfederio1718
    @eleazarfederio1718 3 ปีที่แล้ว

    your youtube channel is very informative

  • @evanceomondi
    @evanceomondi 3 ปีที่แล้ว

    Thanks for the wonderful video.what I have been looking for.

  • @thatsenam9183
    @thatsenam9183 3 ปีที่แล้ว +2

    Awesome explanation.