Code review from a future Tech Lead at Google: :D Prefer for loop to for each loop. Boxing and unboxing Integer/int values is expensive and unnecessary. Switching to a for loop will half your runtime. This isn't C, in Java land we don't use underscores, camelCase is preferred. '++' is more conventional than '+= 1' 3rd "if" is unnecessary it's the same condition as the previous else condition. HashMap of constant size is not more space in big O notation (still O(1) space). It's constant space as it does not grow with the size of the input array. You actually generate far more memory allocations boxing and unboxing memory in your for each loop. Overall you are a great problem solver but a little sloppy. I look forward to watching some of your more recent videos to see how you have progressed. :)
Great video, I spent so much time on leetcode solving this, then as soon as I saw "can be solved using sliding window". Solved it in 5 minutes. Need to memorize which question uses what!
I have this weird problem, when I go to leetcode to try some problems, I can't figure out how to solve (50% of the time), but when I watch your video just for first 1-2 min (until you explain the problem), and then I try to solve, I get all the solutions in my mind and solve that exact problem without watching the rest of your video and after solving the problem when I compare your sol to mine, its same(~80%) :)
You are the man... I still suck at these... but watching you solve and transcribing... makes me understand them a little bit more.. so thanks for being a rock star!
hey nick ,go check that guy Mr K solution of merging KSorted list .he solved with very bade time and space complexity .rather then just adding the head only for the heap,he added all the element of all the lists .yes you are smarter ,but u need to work on your explanation .not all people like me and u can easily understand complicated stuff.good luck man .
haha nick your solution is fab. And i know hashmap dude...you nailed it!!! if you could help me with 1) Expressive Words, 2)Most Stones Removed with Same Row or Column ,3) Evaluate Division and 4th Maximize Distance to Closest Person all of them on leetcode and i am struggling with these
If following along with too many if-else statements in the video, here's the easily readable and understandable code def max_fruits_in_basket(trees): basket1= -1; c_b1 = 0 basket2 = -1; c_b2 = 0 max_counts = 0 for fruit in trees: if fruit == basket2: c_b2 += 1 if fruit == basket1: c_b1 += 1 if (fruit != basket1) and (fruit != basket2): max_counts = max(max_counts, (c_b1 + c_b2)) basket2 = basket1 c_b2 = c_b1 basket1 = fruit c_b1 = 1 return max_counts
Dude, amazing. I spent a lot of time-solving this question and finally, after watching your video I understood the problem. Still, it was a little difficult to understand your solution for a beginner like me. It will be really good if you can explain this in more detail.
Bro he has explained in great detail already !, if you are stuck then I recommend watching some easy related problems to get the hang of it. A good start would be Kadane's algorithm.
this is such a poorly worded problem Input: [1,0,1,4,1,4,1,2,3] Output: 6 Expected: 5 I kept thinking that i had to maintain the count of the secondLastFruit, so the answer would be [1,1,4,1,4,1] but this problem is actually find the largest subarray that contains 2 numbers which is [1,4,1,4,1]
Both the videos(yours and hashmap guy) didn't go well in explaining "how you arrived to the solution",Everybody knows its a sliding window approach , what we need is to have simple and non-clumsy explanation. Your approach works for basket=2 and you did not optimise anything (using four counter variables) and your video 's goal should be to make people understand and benefit from your coaching, neither did hashmap video guy explained it better. What the audience is looking for making the underlying concept clear ! P.S " no hard feelings/hatred comments" ,Just a disappointed user.
just letting you know but i made all these leetcode videos with no subscribers at the time so i didn’t expect to be teaching at such large scale otherwise i would’ve tried a lot harder sorry!
@@NickWhite I appreciate your contribution to other problems where I have liked and saved it for future reference, but honestly I strongly feel the purpose of video was to help people , we can still get ready code in "leetcode " discussions forum/google itself, we come here to get in depth solution /why it works the way it is. There is no doubt you're good programmer ,but some times we need little more than that, a better coach. I have not come here to put hatred comments ,just providing my inputs when I had a hope that this video would actually make me understand to the problem's underlying concept(after going over 10 videos for this problem solution). Again , I appreciate for the efforts in all your videos .Keep doing the good work.
@@RanjuRao yeah no im just trying to explain to you i made all of these not really with the idea that a lot of people would watch them i was more so just documenting myself doing them and some people watched them
![ไข้ขึ้นเลย! เมื่อแฝดโดนจัดเต็มวัคซีนครบ2เดือน🤒 [cc] แดนแพทตี้ SS2 | EP.54 |](http://i.ytimg.com/vi/z2VHItnyyvY/mqdefault.jpg)
Nick refers to kevin in this video , finally secret unveiled 😆😆
A hashmap that stays size 2 is O(1) space.
what if we have n baskets?
I was just about to comment this lol
@@cobrafriends then we have n variables as well
really??
Only problem with this solution is when you have K baskets. Will you be keeping K variables then?
We can also put the code of last if block into the else part where you checked fruit==last_fruit.
Code review from a future Tech Lead at Google: :D
Prefer for loop to for each loop. Boxing and unboxing Integer/int values is expensive and unnecessary. Switching to a for loop will half your runtime.
This isn't C, in Java land we don't use underscores, camelCase is preferred.
'++' is more conventional than '+= 1'
3rd "if" is unnecessary it's the same condition as the previous else condition.
HashMap of constant size is not more space in big O notation (still O(1) space). It's constant space as it does not grow with the size of the input array.
You actually generate far more memory allocations boxing and unboxing memory in your for each loop.
Overall you are a great problem solver but a little sloppy. I look forward to watching some of your more recent videos to see how you have progressed. :)
this is a very thoughtful code review; bet you're doing great at your new position :D
future tech lead, please hire me. lol
Great video, I spent so much time on leetcode solving this, then as soon as I saw "can be solved using sliding window". Solved it in 5 minutes. Need to memorize which question uses what!
so far as the question involves contiguous subarray then sliding window can be used
I have this weird problem, when I go to leetcode to try some problems, I can't figure out how to solve (50% of the time), but when I watch your video just for first 1-2 min (until you explain the problem), and then I try to solve, I get all the solutions in my mind and solve that exact problem without watching the rest of your video and after solving the problem when I compare your sol to mine, its same(~80%) :)
That other dude is @Kevin Naughton Jr.
Thank You For the video Nick ..........🙏🏻🙏🏻🙏🏻🙏🏻🙏🏻🙏🏻
“What is the most amount of fruit you can carry", where is the word "most" in the question?
I saw other videos but the best explanation for this problem is yours. The sliding window.
instead of for each I did:
for (int i = 0, fruitsLength = fruits.length; i < fruitsLength; i++) {
int fruit = fruits[i];
You are the man... I still suck at these... but watching you solve and transcribing... makes me understand them a little bit more.. so thanks for being a rock star!
hey nick ,go check that guy Mr K solution of merging KSorted list .he solved with very bade time and space complexity .rather then just adding the head only for the heap,he added all the element of all the lists .yes you are smarter ,but u need to work on your explanation .not all people like me and u can easily understand complicated stuff.good luck man .
Nick White is pumped up..!!!
This approach gets easier to understand after understanding the hash map approach. So try both.
haha nick your solution is fab. And i know hashmap dude...you nailed it!!! if you could help me with
1) Expressive Words,
2)Most Stones Removed with Same Row or Column
,3) Evaluate Division
and 4th Maximize Distance to Closest Person
all of them on leetcode and i am struggling with these
Thank you, Sir. Brilliant!
Really liked this video, one of your best work dude.
I really wish the variable names were more suited to the problem.
Amazing. Thanks for this
Hey @Nick ...u very much resembles like a character in Harry Potter..
Thanks for easy explanation ;)
Sliding windows are the most irritating one
Thank you Nick. I do know the guy you are speaking about. I agree your solution is good. Please leave your twitter handle if you are on it.
did you mean kevin ;-)
I think so
Awesome Dude..Thanks for the explanation :)
If following along with too many if-else statements in the video, here's the easily readable and understandable code
def max_fruits_in_basket(trees):
basket1= -1; c_b1 = 0
basket2 = -1; c_b2 = 0
max_counts = 0
for fruit in trees:
if fruit == basket2:
c_b2 += 1
if fruit == basket1:
c_b1 += 1
if (fruit != basket1) and (fruit != basket2):
max_counts = max(max_counts, (c_b1 + c_b2))
basket2 = basket1
c_b2 = c_b1
basket1 = fruit
c_b1 = 1
return max_counts
Won't work for {1,2,1,1,4,4,5,5,4,5}
This video did not age well. The hash map is be the better approach, in case the no of basket increase your code won't work
Dude, amazing. I spent a lot of time-solving this question and finally, after watching your video I understood the problem. Still, it was a little difficult to understand your solution for a beginner like me. It will be really good if you can explain this in more detail.
Bro he has explained in great detail already !, if you are stuck then I recommend watching some easy related problems to get the hang of it. A good start would be Kadane's algorithm.
this is such a poorly worded problem
Input:
[1,0,1,4,1,4,1,2,3]
Output:
6
Expected:
5
I kept thinking that i had to maintain the count of the secondLastFruit, so the answer would be [1,1,4,1,4,1]
but this problem is actually find the largest subarray that contains 2 numbers which is [1,4,1,4,1]
It's says add fruit to your basket. If you cannot then stop. You cannot add more that 2 types so it stops at the 4.
Good one!
I would probably use slightly more simple approach. More readable:
for (int i = 2; i < trees.length; i++) {
int fruit = trees[i];
if (fruit != lastFruit && fruit != secondLastFruit) {
isNewFruit = true;
} else {
isNewFruit = false;
}
if (!isNewFruit) {
currentCount++;
if (fruit == lastFruit) {
lastFruitCount++;
} else {
lastFruitCount = 1;
}
} else {
secondLastFruit = lastFruit;
lastFruit = fruit;
lastFruitCount = 1;
currentCount = 2;
}
maxCount = Math.max(maxCount, currentCount);
}
Savior
Both the videos(yours and hashmap guy) didn't go well in explaining "how you arrived to the solution",Everybody knows its a sliding window approach , what we need is to have simple and non-clumsy explanation. Your approach works for basket=2 and you did not optimise anything (using four counter variables) and your video 's goal should be to make people understand and benefit from your coaching, neither did hashmap video guy explained it better. What the audience is looking for making the underlying concept clear ! P.S " no hard feelings/hatred comments" ,Just a disappointed user.
just letting you know but i made all these leetcode videos with no subscribers at the time so i didn’t expect to be teaching at such large scale otherwise i would’ve tried a lot harder sorry!
@@NickWhite I appreciate your contribution to other problems where I have liked and saved it for future reference, but honestly I strongly feel the purpose of video was to help people , we can still get ready code in "leetcode " discussions forum/google itself, we come here to get in depth solution /why it works the way it is. There is no doubt you're good programmer ,but some times we need little more than that, a better coach. I have not come here to put hatred comments ,just providing my inputs when I had a hope that this video would actually make me understand to the problem's underlying concept(after going over 10 videos for this problem solution). Again , I appreciate for the efforts in all your videos .Keep doing the good work.
@@RanjuRao yeah no im just trying to explain to you i made all of these not really with the idea that a lot of people would watch them i was more so just documenting myself doing them and some people watched them
Nice explanation , I have watched same video from another TH-camr but I didn't understand. Thanks for your simple explanation
who is that.
@@a.yashwanth kevin naughton jr
great anyway
confusing code and explanation .
he never used max variable .
Are you dumb?
gajab chodu ho bhai!
@@nidhishgautam5985 lol