Improve your Rust APIs with the type state pattern

แชร์
ฝัง
  • เผยแพร่เมื่อ 12 มิ.ย. 2024
  • Today I'm teaching you how to build Rust APIs that are impossible to misuse by taking advantage of generics and zero-sized types!
    FREE Rust Cheat Sheet: letsgetrusty.com/cheatsheet
    Code: github.com/letsgetrusty/gener...
    Chapters:
    0:00 Intro
    0:28 Example overview
    2:30 First solution
    4:20 Second solution
    8:13 Third solution
    14:18 Outro
  • วิทยาศาสตร์และเทคโนโลยี

ความคิดเห็น • 275

  • @letsgetrusty
    @letsgetrusty  ปีที่แล้ว +24

    📝Get your *FREE Rust cheat sheet* :
    www.letsgetrusty.com/cheatsheet
    Corrections:
    10:00 - PhantomData isn't needed here. The Locked and Unlocked structs are already zero-sized types.
    11:40 - The lock method should return PasswordManager

    • @kennethbeal
      @kennethbeal ปีที่แล้ว +1

      That was great, thank you! Amazing how it catches so many errors before even running; and, the hints are dynamic as well. Nicely demonstrated.

    • @xokelis0015
      @xokelis0015 2 หลายเดือนก่อน

      There is a bug in your final lock() method on lines 27 and 31, since it just returns an unlocked password manager. You should change the state to locked in both lines. Other than that minor issue, great vid.

  • @jeffg4686
    @jeffg4686 ปีที่แล้ว +173

    I like the idea of using "types" as "markers" of sorts (regarding using generics on a struct just for differentiation). Better than using a field as that's runtime data.This was a great little video. Helped me see things a little different. A "rust patterns" mini-series would be good. Definitely some distinctions from other languages.

    • @shinobuoshino5066
      @shinobuoshino5066 4 หลายเดือนก่อน +2

      Lmao, this was done in OOP for past 50 years.

    • @1____-____1
      @1____-____1 9 วันที่ผ่านมา

      @@shinobuoshino5066What does OOP have to do with the topic of the video? This is about encapsulation verification (access control) at compile time via Rust's type system. How does OOP do the same via types?

  • @VictorGamerLOL
    @VictorGamerLOL ปีที่แล้ว +270

    You mistyped the lock method it still returns an unlocked password manager

    • @letsgetrusty
      @letsgetrusty  ปีที่แล้ว +105

      Good catch, it should be locked.

    • @mihaigalos279
      @mihaigalos279 ปีที่แล้ว +33

      @@letsgetrustyI suggest to always return Self to simplify refactoring and guard against such cases for the future. One can also construct and return a Self {}.

    • @brdrnda3805
      @brdrnda3805 ปีที่แล้ว

      @@mihaigalos279 Isn't Self the wrong type? If you call unlock then Self is PasswordManager but you want to return a PasswordManager

    • @FryuniGamer
      @FryuniGamer ปีที่แล้ว +68

      ​@@mihaigalos279 can't use Self when changing the state since Self represent the type with the current state

    • @Galaf
      @Galaf ปีที่แล้ว +3

      Thank you, I thought I was going crazy.

  • @EngineerNick
    @EngineerNick ปีที่แล้ว +40

    Brilliant thank you! PyO3 (the rust crate for python extensions) uses this method to confirm the user has the GIL (Global interpreter Lock). At the time I gave up trying to understand the phantom data, but thanks to you I understand now! Now if only there was a way to make the macros that crate uses less mysterious...

  • @Ether_Void
    @Ether_Void ปีที่แล้ว +21

    Soon it might also be possible to define states in an enum using const generics. Currently this requires the unstable "adt_const_params" feature, otherwise you could only be allowed to use integer and char types which isn't really readable.
    This would have the benefit that it's easier to see what states are possible currently there is no real connection between the Locked and Unlocked types and the PasswordManager other than the impl blocks.

  • @jonesmartins
    @jonesmartins ปีที่แล้ว +5

    This is the first time I understand PhantomData. Thanks!

  • @diarmaidmac2149
    @diarmaidmac2149 ปีที่แล้ว +7

    Amazing video. Thank you! This solution is very elegant. Thank you for exploring the initial, non-optimal solutions first. It makes it easy to see the benefits of the final solution.

  • @embeddedbastler6406
    @embeddedbastler6406 ปีที่แล้ว +24

    As an alternative implementation, we could have the unlock method return an owned token that is a required parameter for the list_passwords method. Upon locking, the token is consumed again by the PasswordManager.

    • @GrzesiuG44
      @GrzesiuG44 ปีที่แล้ว +5

      This is definetly the proper way to solve this specific problem. Not only you get compile time checks for API usage, but your API is now closer to supporting being unlocked independently in two different functions.

    • @tubebrocoli
      @tubebrocoli ปีที่แล้ว

      @@GrzesiuG44 however, this requires allocating extra data, which isn't what the demo was trying to demonstrate.

    • @oleh1
      @oleh1 9 หลายเดือนก่อน

      @@tubebrocoli cannot this token be a zero-sized struct too? "struct Token;" If it can, how does passing a zero-sized struct as a function parameter affect the function's call stack?

  • @henrywang6931
    @henrywang6931 ปีที่แล้ว +12

    The type state pattern, love it!

  • @TehKarmalizer
    @TehKarmalizer ปีที่แล้ว +6

    It’s a beautiful use of the type system. Definitely gives me something to think about.

  • @codebycarlos
    @codebycarlos 7 หลายเดือนก่อน +1

    Wow man. First 12 hours with Rust and it has already blown my mind so many times.

  • @varantavers
    @varantavers ปีที่แล้ว +1

    Recently I have came across a situation where I had to do something similar and this video immediately came to my mind. Nice work!

  • @lukasz_kostka
    @lukasz_kostka ปีที่แล้ว

    Fantastic. I love short, to the point tutorials like this.

  • @trashhater9304
    @trashhater9304 ปีที่แล้ว

    This is awesome! Almost the same thing was implemented in ATS2 Postiats socket library, which is basically a header files for interop between "C". It uses something like the phantom types but with the refinement types. So not only you can describe the exact flow for you api, but also bind this flow with actual values you pass into functions. This is done via dependent type system

  • @vanish3408
    @vanish3408 ปีที่แล้ว +17

    I'm pretty sure you don't have to specify the type of PhantomData since it would be done by the compiler, aside from that very small thing, this is one of your best videos so far. It's providing information on an intermidiate level while being explained very well!

    • @julytikh
      @julytikh 11 หลายเดือนก่อน +4

      Indeed, usage of `PhantomData` seems redundant since `State` is already a zero-sized type.
      (BTW, there is another error: in the third solution, the method `lock()` should return a `PasswordManager`, not `PasswordManager`.)

    • @user-bj2tz8qg6g
      @user-bj2tz8qg6g 8 หลายเดือนก่อน +1

      @@julytikh Yeah, I also noticed both errors. But the video is still great!

    • @tri99er_
      @tri99er_ 4 หลายเดือนก่อน

      I'm new to Rust, but I felt weird, when he said, that just using "State" would take up memory, since Locked amd Unlocked are zero sized types, just like PhantomData. I'm glad to see, that I wasn't mistaken.
      What are idiomatic uses of PhantomData then? I know, it can "own" nonzero size types (e.g. PhantomData), but when is it useful compared to using just plain unit structs?
      The only thing I can see, is if somebody by mistake created PasswordManager (which wouldn't be prevented by compiler), they'd be wasting some memory in case, where "state: State" ("state: i32": size is equal to size of i32), as opposed to "state: PhantomData" ("state: PhantomData": size is 0).
      But there's a way to restrict the State generic to only include the right types, which would prevent you from creating idiotic types like PasswordManager, which would be even better, than using PhantomData to deal with it.
      You can create a (possibly private) marker trait yourself, let's call LockState and have Locked and Unlocked implement it, and then restrict generic State: LockState. At that point there's no need to use PhantomData in this case, and it's absolutely impossible to create idiotic types (e.g. PasswordManager).
      I guess PhantomData is useful in cases, where your intent is for your type to be able to be marked by any types user of your library wants (e.g. YourType, YourType, YourType). But I don't know of such scenario (because YourType would not actually contain values of those types, it's only marked by them).

    • @MrVulfe
      @MrVulfe 4 หลายเดือนก่อน

      @@tri99er_ One case where this comes up occasionally is when you need a type dependency for the working of your type (e.g. for a return type in one of its methods, for example) but the type isn't actually used in the struct itself. In that situation, you can use a PhantomData to satisfy the compiler that you are "using" the type in the struct so that you can use the parameter in your methods.

    • @julians.2597
      @julians.2597 หลายเดือนก่อน +1

      @@tri99er_ e.g. the implementation of 'dyn Trait'

  • @Charls93xx
    @Charls93xx ปีที่แล้ว +1

    That was super straightforward, thanks for sharing!

  • @schred
    @schred ปีที่แล้ว +1

    Your best video yet in my opinion, thanks for your work! :D

  • @goodwish1543
    @goodwish1543 ปีที่แล้ว +2

    Beautiful! Thanks for sharing. Looking forward to more intermediate Rust contents like this. :)

  • @AntonKravc
    @AntonKravc ปีที่แล้ว

    Great video! I’m just starting to learn rust but everything was explained very clearly. Coming from typescript I’m very excited about the existence of PhantomData.

  • @ShreksSpliff
    @ShreksSpliff ปีที่แล้ว +43

    In some other languages like Haskell they call it the Indexed Monad pattern. Feels pretty similar to me.
    The Rust library called Graph uses this in their builder pattern graph constructor, so it can infer at the type level if your graph is directed or undirected, and if the edges or nodes contains values.
    Also, thanks for this. The non generic example was a nice touch. Should it be put in the lock impl, as it defaults to lock or is this better as it changes with the default state?

    • @chessai2121
      @chessai2121 ปีที่แล้ว

      Indexed Monads are an extension of "plain"-er GADTs with DataKinds. Before those were usable, people used open phantom types. GADTs + DataKinds are more common than indexed monads because a lot of operations can be represented with simple non-monadic functions.

  • @kajacx
    @kajacx ปีที่แล้ว +4

    Nice, saw this once before in a "chaining builder" pattern that prevented setting the same property twice.
    I personally would make UnlockedManager a newtype for &mut PasswordManager, that way, do don't need ownership and you get the re-lock for free when it drops.

  • @leonardogomes5121
    @leonardogomes5121 หลายเดือนก่อน

    Great! Great! Great! The best explanation of the Type State Pattern on TH-cam! You rock man! How can we support your work?

  • @minciNashu
    @minciNashu ปีที่แล้ว +10

    Would be interesting to expand on this further by implementing auto lock on drop, raii style.

    • @kajacx
      @kajacx ปีที่แล้ว

      Just make LockedPasswordManager a newtype for &mut PasswordManager. That way, it makes the locked manager avaliable after it gets dropped automatically thanks to Rust's ownership system.

    • @MrTrollland
      @MrTrollland 9 หลายเดือนก่อน

      u can just impl the Drop trait cant u

  • @TheZdannar
    @TheZdannar ปีที่แล้ว

    This video is hot sauce. I had seen Phantom data before, but did not fully comprehend it. Nice work Bogdan.

  • @andredasilva6807
    @andredasilva6807 ปีที่แล้ว +2

    didnt know about zero types. really nice video. as always keep the great work up

  • @JohnDoe-ji1zv
    @JohnDoe-ji1zv ปีที่แล้ว

    Nice video, really useful, didn’t know about this pattern and state before. Cheers

  • @banniball
    @banniball ปีที่แล้ว +6

    I liked the general concepts of using types to represent the state.
    But wouldn't one problem be that after locking the password manager one could still have a reference to the unlocked one. Since lock/unlock returns a new instance

    • @banniball
      @banniball ปีที่แล้ว +1

      I.e it's not like an FSM with one state but rather a struct where you can have multiple instances all with same content with different state.

    • @MatthiasBlume
      @MatthiasBlume 5 หลายเดือนก่อน +6

      That's the whole point: lock and unlock take their self argument not by reference but by ownership transfer (i.e., move). So the caller loses ownership, and there cannot be any references to the old instance or the whole thing does not typecheck.

  • @chillyvanilly6352
    @chillyvanilly6352 ปีที่แล้ว

    Wow, that was genuinely an awesome vid, thank you!

  • @nirmalyasengupta6883
    @nirmalyasengupta6883 ปีที่แล้ว

    Zero-size Types is new to me. I have learnt something. Thanks. I have used similar approaches in Scala / Java earlier, even though the effort was more. Moreover, in Akka-Typed, the approach is very similar, even though the implementation is cumbersome.
    Thanks again, for uploading this.

  • @jonnyso1
    @jonnyso1 ปีที่แล้ว

    That's the exact feature I needed the other day and I didn't know yet !

  • @AlwaysStaringSkyward
    @AlwaysStaringSkyward ปีที่แล้ว

    I learned a lot from this. Thank you!

  • @CYXXYC
    @CYXXYC ปีที่แล้ว +17

    how would using just state: State waste memory? Isn't it also 0-sized?

    • @koonoho
      @koonoho ปีที่แล้ว +1

      I'm also confused about this. I can certainly see PhantomData being useful if the struct holds some data, but in this case there really shouldn't be any additional memory used.

    • @pawe460
      @pawe460 ปีที่แล้ว +9

      I checked it on goldbolt and both structures with :State and :PhantomData takes 72 bytes for me, so I guess it is optimized out in both variants

    • @Baptistetriple0
      @Baptistetriple0 ปีที่แล้ว +3

      What he is saying is very confusing, if T is a ZST you don't need PhantomData to make it ZS because it already is, PhantomData exist primarly for lifetimes: for example there are structs that owns a pointer for optimizations, but still need to hold the lifetime of the backing data, so you add somewhere a PhantomData

    • @letsgetrusty
      @letsgetrusty  ปีที่แล้ว +4

      It wouldn't, I made a mistake. Will point this out in the pinned comment.

  • @irlshrek
    @irlshrek ปีที่แล้ว

    this was a really good explanation!! thanks for this

  • @kwinzman
    @kwinzman ปีที่แล้ว +1

    I've been doing that instinctively for a long time now. But great example and explanation nontheless! The Rust specifics with the zero-size types was new and pretty informative!

  • @xavhow
    @xavhow ปีที่แล้ว

    This is so useful!
    Thank you for sharing.

  • @mustafazakiassagaf1757
    @mustafazakiassagaf1757 ปีที่แล้ว

    i like this kind of video. keep up the good work man

  • @JUMPINGxxJEFF
    @JUMPINGxxJEFF ปีที่แล้ว +2

    Nicely explained, thanks

  • @AceofSpades5757
    @AceofSpades5757 ปีที่แล้ว

    I haven't seen this one before. Very cool!

  • @Jiftoo
    @Jiftoo 9 หลายเดือนก่อน

    I use this pattern for data sanitisation in my backend. Works great!

  • @ianknowles
    @ianknowles ปีที่แล้ว

    Always handy Bogdan appreciate the share!

  • @miriamramstudio3982
    @miriamramstudio3982 ปีที่แล้ว

    Woow, that was very cool. Great teaching. Thanks

  • @setoelkahfi
    @setoelkahfi ปีที่แล้ว

    This been really useful. Thanks!

  • @EdgeGaming
    @EdgeGaming ปีที่แล้ว

    Beautiful. Will be looking for ways to use this, thanks!

    • @kopuz.co.uk.
      @kopuz.co.uk. ปีที่แล้ว

      you code your password vaults like this? 😱

  • @GAGONMYCOREY
    @GAGONMYCOREY ปีที่แล้ว

    This video is one of your best

  • @Tferdz
    @Tferdz ปีที่แล้ว +8

    Please use Self as a return from your methods, instead of rewriting all the time the struct name. It makes code reformatting wayyyy easier! :)

    • @RoyalVideoPresents
      @RoyalVideoPresents ปีที่แล้ว

      Why? If you rename the struct shouldn‘t the IDE rename that too?

    • @DavidM_603
      @DavidM_603 ปีที่แล้ว +3

      lock() and unlock() do not return Self, they change the type

  • @timvw01
    @timvw01 ปีที่แล้ว +1

    Interesting pattern! My default is to revert to state variables, usually enums.

  • @debuti
    @debuti ปีที่แล้ว

    I think this is maybe your best video

  • @AveN7ers
    @AveN7ers ปีที่แล้ว +1

    Very cool stuff man

  • @Archepter
    @Archepter ปีที่แล้ว

    This was very cool. Thanks !

  • @jma42
    @jma42 ปีที่แล้ว

    thanks for this, I really wondered how typestate pattern works since it was said that it only works well with rust..

  • @Echiduna
    @Echiduna ปีที่แล้ว

    Enjoy this video so much!

  • @flippert0
    @flippert0 6 หลายเดือนก่อน +1

    Very interesting and illuminating ! A while back ago, I was heavily into generating code from UML state diagrams. Generated state machine code either would use a traditional state transition table or state classes. Now duplicated code isn't that much of a problem, if the code is generated anyway, however to avoid duplicatation I could also a use traditional inheritance. So "LockedPasswordManagerr" and "UnlockedPasswordManager" would both inherit from "PasswordManager" which would implement common code (here: "version()" and "encryption"). It never occurred to me, that I could do the same with generics.

    • @tri99er_
      @tri99er_ 4 หลายเดือนก่อน

      There's no inheritance in Rust. And traits don't have access to implementor fields, so you'll end up with the same amount of duplication.

  • @MiterAlmeida
    @MiterAlmeida ปีที่แล้ว

    Loved this video! ❤

  • @thanhatpham3428
    @thanhatpham3428 ปีที่แล้ว

    Thank you, now i know how to do something like inheritance in rust

  • @ImranSheikh-kg4qd
    @ImranSheikh-kg4qd ปีที่แล้ว

    I really like this kind of videos 🤛

  • @antoniong4380
    @antoniong4380 8 หลายเดือนก่อน +1

    Wtf. You can actually do this? So much potential! And head wacking because I need to make sense of the structure

  • @samansamani4477
    @samansamani4477 ปีที่แล้ว

    Thank you, this can become handy

  • @Chastor97
    @Chastor97 ปีที่แล้ว

    Till the end I have been waiting for raii cause I think it fits here well

  • @kirillgimranov4943
    @kirillgimranov4943 ปีที่แล้ว

    Nice stuff, it'll help a lot

  • @haydn.murray
    @haydn.murray 11 หลายเดือนก่อน

    This was great!

  • @_jdfx
    @_jdfx ปีที่แล้ว

    Really cool! thanks Bogdan!

  • @alexandersemionov5790
    @alexandersemionov5790 ปีที่แล้ว

    interesting, looks like a builder pattern, but returns an instance of same struct with just a state 0 size in memory and template reference thing. Great combo

  • @TadaHrd
    @TadaHrd ปีที่แล้ว

    This was relay helpful. I couldn't come up with such a smart system. However, you should have a State trait that is implemented for the two state types.

  • @stephenreaves3205
    @stephenreaves3205 ปีที่แล้ว

    This was beautiful

  • @heret1c385
    @heret1c385 23 วันที่ผ่านมา

    great pattern. Man, I just love rust.

  • @MrLunarpulse
    @MrLunarpulse ปีที่แล้ว

    Awesome this is the idiomatic way of using Rust type system for states. It van be also extended to state machine or state chart.

  • @sgq995
    @sgq995 ปีที่แล้ว

    Great video!

  • @nocodenoblunder6672
    @nocodenoblunder6672 ปีที่แล้ว

    This looks amazing. But is only suitable for state that changes infrequently right? Whenever we transform from one state to another, we are creating a copy of the structs fields

  • @timvw01
    @timvw01 8 หลายเดือนก่อน +1

    In the last example, if you switch states, does rust have to move all the data to the new struct? So its basically allocating a whole new object when switching states?

  • @nerdbot4446
    @nerdbot4446 ปีที่แล้ว +1

    Can you also create an impl block that defines methods for multiple states?
    There might be methods that shouldn't exist in all states, but in some.

  • @cameronhunt5967
    @cameronhunt5967 ปีที่แล้ว

    Does the compiler help make sure you handle all possible states for structs as it does in match statements?

  • @skyeplus
    @skyeplus ปีที่แล้ว +3

    This example is consuming previous state, which is fine. Can you make a proxy type holding reference instead?

    • @julians.2597
      @julians.2597 หลายเดือนก่อน +1

      it intentionally consumes self to prevent dangling references to previous states

  • @jameskoh3463
    @jameskoh3463 2 หลายเดือนก่อน

    I like TypeScript exactly because it provides similar functionality to implement this 👍

  • @soberhippie
    @soberhippie 11 หลายเดือนก่อน +1

    The problem I ran into is when I try to implement a trait for such state-parameterised struct, I either get "trait not implemented" or "duplicate definitions with the name " errors.

  • @adambutler2646
    @adambutler2646 ปีที่แล้ว

    great video. thank you

  • @Therzok1
    @Therzok1 ปีที่แล้ว +2

    The lock function returns an Unlocked PasswordManager, instead of a locked one.

  • @ddystopia8091
    @ddystopia8091 ปีที่แล้ว

    Incredible!

  • @Bonta768
    @Bonta768 ปีที่แล้ว

    Excellent. I really enjoyed learning this one.
    What minimum version of Rust can you use this pattern on?

    • @EvanBoldt
      @EvanBoldt ปีที่แล้ว +2

      Looks like the PhantomData struct is since 1.0.0. I don’t see when default generics were added but there’s a spec for it from 2015.

  • @ahmedhassanahmedhassan6495
    @ahmedhassanahmedhassan6495 ปีที่แล้ว

    Thanks 4 z great videos :)

  • @erlangparasu6339
    @erlangparasu6339 ปีที่แล้ว

    thank you so much 🙏

  • @rsalmei
    @rsalmei 11 หลายเดือนก่อน

    It does not need both the default generic type and the last impl block. Just define `new()` in whatever state you want it, e.g. in the `impl PasswordManager` block.

  • @Matt23488
    @Matt23488 ปีที่แล้ว

    In the third solution, you didn't update the lock() method to return a locked password manager. But it doesn't matter, you got the point across and I bet many people didn't even notice.

  • @skpz7335
    @skpz7335 ปีที่แล้ว

    Nice video thanks

  • @loganhodgsn
    @loganhodgsn ปีที่แล้ว +1

    Since Locked and Unlocked are Zero-Sized Types (ZST's), why do we need to use PhantomData? What if our state needed to carry a little bit of information? (such as who unlocked it)

  • @tabiasgeehuman
    @tabiasgeehuman ปีที่แล้ว +3

    How did you get your "todo!()"s highlighted like that? Looks really helpful.

    • @ex0ze
      @ex0ze ปีที่แล้ว +1

      Seems like TODO Highlight vscode extension

    • @letsgetrusty
      @letsgetrusty  ปีที่แล้ว +9

      The todo-tree VSCode extension + adding this line to settings.json:
      "todo-tree.regex.regex": "(//|#|

    • @tabiasgeehuman
      @tabiasgeehuman ปีที่แล้ว

      @@letsgetrusty TY

  • @alerya100
    @alerya100 19 วันที่ผ่านมา

    Amazing !

  • @jay-tbl
    @jay-tbl ปีที่แล้ว

    How do you include another generic type with bounds? Say I want my password manager to also store another value, and I want that value to implement a list of traits. In each impl block I would have to specify that my generic type needs to implement the traits. How can I do this without repitition?

  • @wumwum42
    @wumwum42 ปีที่แล้ว

    I think in the final solution, you can merge the first and 4th impl. PasswordManager and PasswordManager is the same

    • @rad9587
      @rad9587 ปีที่แล้ว

      This is correct, but I think it's clearer, because we are not creating a locked manager, but just a manager(Even though it will be locked anyway)

  • @Beastpig41
    @Beastpig41 ปีที่แล้ว

    Great video

  • @jaumesinglavalls5486
    @jaumesinglavalls5486 ปีที่แล้ว

    why the lock method returns the state Unlocked? It should return the state Locked, right? Also, in rust should be possible to force the manager cannot be used after calling to lock or unlock? (to force do the switch of the variable?)

  • @Spiun666
    @Spiun666 11 หลายเดือนก่อน

    Given that you consume the original password manager, is it necessary to clone the members of the struct (password list and string)

  • @fumseck
    @fumseck ปีที่แล้ว +5

    How feasible would it be to do it the way Mutexes work, with the lock being held only until out of scope ?

    • @inx1819
      @inx1819 ปีที่แล้ว

      this is what I thought the video would be about

    • @chhelms
      @chhelms ปีที่แล้ว +2

      You could normally do that by implementing drop on the unlocked password manager and calling the lock method, except his lock consumes self and you only have a &mut self when implementing drop so I'm not sure. I guess in a real use case, lock would have some other functionality that encrypts the passwords and writes it to a file for example, which would be available to call in the drop implementation, so you could do that at least.

    • @Turalcar
      @Turalcar ปีที่แล้ว

      This API prevents calling lock twice while for mutexes calling lock twice (usually from a different thread) is the point. I suppose you could create a Mutex API such that each client gets issued a reference wrapped in a way that prevents lock being callable the second time on the same reference.

  • @dmdeemer
    @dmdeemer ปีที่แล้ว

    Bogdan,
    Rust neophyte here. I get confused sometimes when my variables get consumed when I don't expect them to be.
    How do you know quickly when a variable is going to be consumed, either by using it as a function parameter, calling an implemented method on it, or even iterating over a vector? Do you just have to be aware of the exact syntax of every function call?
    Also, in the Type-State pattern is there any way to avoid moving each member from one state of the type to the next? That could get tedious for a non-trivial number of states or members.

  • @shufflecat3334
    @shufflecat3334 ปีที่แล้ว +1

    So how do we handle the case where the client gets the password wrong? The unlock method should either return an unlocked manager or a locked manager...or panic I guess?

  • @Artentus
    @Artentus ปีที่แล้ว +7

    Instead of zero sized structs you can use empty enums here. They are not only zero sized but actually not constructible.

    • @diadetediotedio6918
      @diadetediotedio6918 ปีที่แล้ว

      This would solve the problem of user building the wrong state by itself

    • @ErikCampobadal
      @ErikCampobadal ปีที่แล้ว +1

      The issue is that you can't implement different functionality on a struct based on an enum variant. Therefore, we only know if the manager is locked/unlocked at runtime, resulting in panics or results like the first solution. As he showcased, generics allows multiple implementations. The only concern I have is restricting the available State variants, since his implementation allows arbitrary types to it. Perhaps having a sealed trait would solve this as a constraint => pub type PasswordManager {}

    • @Artentus
      @Artentus ปีที่แล้ว +4

      @@ErikCampobadal You didn't understand me correctly. I'm saying turn `struct Locked;` into `enum Locked {}`, an enum with 0 veriants which is a non-constructible type in Rust.

    • @ErikCampobadal
      @ErikCampobadal ปีที่แล้ว

      @@Artentus ahh interesting, indeed. This combined with a sealed trait could be a great solution

    • @Wodziwob
      @Wodziwob ปีที่แล้ว

      Would you say this is the better approach? Is it less common?

  • @martinbecker1069
    @martinbecker1069 ปีที่แล้ว +3

    This perfectly explains Phantom Data types, I never really grokked this but this instantly made me understand and Now I can see how it can be used in other places! It kind of reminds me of how Two structs of the same Type but with different life-times are treated as two completely separated types so you can't return something with the wrong life-time.

    • @julytikh
      @julytikh 11 หลายเดือนก่อน

      Actually, `PhantomData` is redundant in this particular case. The types `Locked` and `Unlocked` are already zero-sized (because they have no fields), and `PhantomData` does not improve upon that.

    • @LukasCobblerxD
      @LukasCobblerxD 10 หลายเดือนก่อน

      @@julytikh can you explain how not to use the phantom data in this example

    • @julytikh
      @julytikh 10 หลายเดือนก่อน +1

      @@LukasCobblerxD just use `State` instead of `std::marker::PhantomData`.

  • @NoahSteckley
    @NoahSteckley ปีที่แล้ว

    Would an enum LockedStatus work well here too?

  • @officialismailshah
    @officialismailshah ปีที่แล้ว

    Best vid❤❤❤❤

  • @b_mathemagical
    @b_mathemagical 26 วันที่ผ่านมา

    This is great. Quick question (for anyone): why have an impl block with the generic state and then one for the type as a whole? E.g. why can’t the new method live in the generic impl block? Or vice versa - why can’t the shared methods live in the impl block for PasswordManager?

  • @codeman99-dev
    @codeman99-dev ปีที่แล้ว

    What's the advantage over just using an enumeration of the password manager?