Dynamic objects should NOT be this hard

แชร์
ฝัง
  • เผยแพร่เมื่อ 17 พ.ย. 2024

ความคิดเห็น •

  • @Relaxantify
    @Relaxantify ปีที่แล้ว +34

    "Technically you could index into my object with D"
    That's a pick up line I haven't heard before

  • @helleye311
    @helleye311 ปีที่แล้ว +27

    I've done all 3, for different use cases. Last one in particular is nice if you really just want TS to shut up and let you handle it. Sometimes there's some fancy logic in the function above to check if it'll work, but you still want autocomplete on the results in one form or another, and these might not agree with the object type, and typescript doesn't quite narrow things down as much as I'd like it to. Then as keyof typeof obj is a real life saver. You could do it in a safer manner, but it would almost always involve very abstract types and a lot of headache.
    Definitely a sharp knife that one, that's a great analogy.

    • @FlyingPenguino
      @FlyingPenguino ปีที่แล้ว

      Sometimes putting `// @ts-expect-ignore` above the line is nice as well ;) If you're casting, you're ignoring type-safety anyway. Use it wisely!

    • @brucewayne2480
      @brucewayne2480 ปีที่แล้ว

      I Generally avoid using the keyword as unless it's some communication with the external world like db or api

  • @jon1867
    @jon1867 ปีที่แล้ว +7

    Something confusing but actually kind of necessary (due to how JS works) that I think you could have mentioned here is how Record is still technically creating strings that point to type T.
    It's why I think for dynamic options, Map can be a little nicer to work with in Typescript.

    • @jaroslavoswald7566
      @jaroslavoswald7566 ปีที่แล้ว +3

      Can you elaborate more? I tried to read that statement few time, but it doesnt make sense to me. How is `Record` creating string that point to T?

    • @jon1867
      @jon1867 ปีที่แล้ว

      @@jaroslavoswald7566 The idea is any time you go to take a dynamic record and turn it into something useful for calculating something, it gets deserialized to a string.
      Object.keys({1: "hello"})
      turns into
      ["1"]

    • @gmoniava
      @gmoniava ปีที่แล้ว +1

      ​​​​@@jaroslavoswald7566I think he means in js if use number as index it gets converted to string. So the type of key will be string | number in the case he refers to. But can't check now.

  • @culi7068
    @culi7068 ปีที่แล้ว +1

    Solution #4 is ugly because of problems with conditional types as return types but you can do:
    ```ts
    const myObj = { a: 12, b: 'hello' };
    type Unlocked = T extends keyof typeof myObj ? typeof myObj[T] : undefined;
    const access = (key: T): Unlocked =>
    myObj[key] as Unlocked
    ;
    ```
    And then you get
    ```ts
    const something = access('a');
    // ^? number
    const somethingElse = access('b');
    // ^? string
    ```

  • @FlyingPenguino
    @FlyingPenguino ปีที่แล้ว +2

    4th option: `// @ts-expect-error` above the line. It's almost explicit sign for people reading the code that the developer just wanted typescript to shut up. It might lead to leaner code tbh. As long as such stuff is contained in small edge-case functions. It's probably fine :)

    • @mattpocockuk
      @mattpocockuk  ปีที่แล้ว +4

      That'll leak an 'any' into the rest of the codebase! Best avoided.

  • @mahadevovnl
    @mahadevovnl ปีที่แล้ว +20

    Honestly, this kind of example shows how absolutely batshit insane TS is for newcomers. Its error messages so very often don't make a shred of sense. They really need to either make TS better (they are continually doing so anyway) or make the error messages more sensible.
    I'm almost never reading TS errors anymore. It goes straight into ChatGPT and then it makes sense about 5 seconds later.

    • @disinfect777
      @disinfect777 ปีที่แล้ว +4

      TS is an attempt to fix a crappy language but it's so crappy there's always gonna be these weird quirks and bugs. What needs to be done is getting rid of JS and let us use a proper language in the browser. If i could use c# both back and front end I'd be so happy.

    • @mahadevovnl
      @mahadevovnl ปีที่แล้ว

      @@disinfect777 I have no issues with JavaScript, and I don't need TypeScript. The only reason I use it is because companies insist on it.

    • @Delphi80SVK
      @Delphi80SVK ปีที่แล้ว

      and without TS you will get noticed at runtime with plain JS about such string|undefined errors, especially in production. TS tries to help you when writing code.

    • @mahadevovnl
      @mahadevovnl ปีที่แล้ว +2

      @@Delphi80SVK I've worked with vanilla JavaScript for over 16 years. Coding conventions, naming conventions, JSDoc, etc. all did the trick perfectly fine.
      TypeScript also COSTS a lot of time trying to figure out its stupidities (like pointed out in this video), and trying to figure out some genius's 5 nested single-letter generics.

    • @gmoniava
      @gmoniava ปีที่แล้ว +1

      ​@@mahadevovnlyes some people overtype things

  • @eqprog
    @eqprog ปีที่แล้ว

    One “gotcha” of keyof is that you can not use keyof Whatever if Whatever[key] is a private member. Extremely frustrating in certain scenarios.
    Another is if you are using a mapped types and then the corresponding keyof Type as a function parameter. “Type string cannot be used to access type string | number | Symbol”
    This one is particularly perplexing.

  • @n3ko74
    @n3ko74 ปีที่แล้ว

    What about writing `Record` instead? Doing to much or too little is always cause trouble and confusion.

  • @edgeeffect
    @edgeeffect ปีที่แล้ว +1

    Anybody else from Python or PHP saying "wow, I wish we had something like TypeScript in our world"?

  • @linkfang9300
    @linkfang9300 ปีที่แล้ว

    I just used the last one today and I did not come up with another solution. In short, it could be very useful when typescript can not infer the type correctly, when using Object.keys() or some array method (filter(), etc.).
    So my case is that I have a constant object (defined using as const) and its key and value are strict type (let's say, key is "a | b", value is "1| 2"). I would like to generate an array of object, like this {label: "a" | "b", value: 1 | 2}[], to be used as the option for a select component. The easiest way I can think of is to use "Object.keys()" or "Object.entities()" and then map through it to get the array. The issue then starts, typescript will NOT infer the type of the key to be "a" | "b" but string (the value will be inferred as 1 | 2 though). And because of the string, I can not use it as a index to get the value and or make the new array to have the strict type I would like to have. The type would be {label: string, value: 1 | 2}[] which is far from perfect. So I have to cast the type of the key to be "a" | "b" and it will only be this because the whole object is readonly and nothing can be changed.

    • @jaroslavoswald7566
      @jaroslavoswald7566 ปีที่แล้ว

      For this situations I have always in utils my own `keys` or `entries` functions. But they are generic and they are correctly infering key as string literals. It loooks like this:
      const keys = (obj: T) => {
      return Object.keys(obj) as Array
      }
      const result = keys({ a: 1, b: 2 })
      // ^? const result: ("a" | "b")[]

  • @NaorBK
    @NaorBK ปีที่แล้ว

    When will you ever use option 3 instead of option 1? I'm not quite sure how the `for loop` you mentioned could lead you to use 3. after all, the iterator should have an array of all possible types of keys.

  • @vahan-sahakyan
    @vahan-sahakyan ปีที่แล้ว

    2:56 A quick question: Will there ever be a time when FOR..IN loop will be typed?

    • @mattpocockuk
      @mattpocockuk  ปีที่แล้ว

      No - TypeScript would have to support exact object types, which I don't think it will ever do.

  • @thepetesmith
    @thepetesmith ปีที่แล้ว +54

    If you ask me, working at Vercel is higher than FAANG.

    • @josipX
      @josipX ปีที่แล้ว +2

    • @brokula1312
      @brokula1312 ปีที่แล้ว +10

      Why? Most of tech influencer don't really have extensive experience. Also, Vercel is overrated as is Next. There are far better, easer and more intuitive technologies out there.

    • @steamer2k319
      @steamer2k319 ปีที่แล้ว +6

      The guys from JetBrains are really sharp, too. It depends on who you get from FAANG. Those are big companies with a lot of variation across the many engineering teams.

    • @CHAPI929292
      @CHAPI929292 ปีที่แล้ว +1

      ​​@@brokula1312examples of such technologies?

    • @BeepBoop2221
      @BeepBoop2221 ปีที่แล้ว

      ​@@brokula1312such as?

  • @sam.0021
    @sam.0021 ปีที่แล้ว

    This is something I've found extremely annoying when using string flags where I want undefined, null, or empty string to be an option and then I want to index an object with these strings. TS almost always makes me either lie to it (and thus force me to always remember my lie) or create a "dummy" key in my object.

  • @sqlazer
    @sqlazer ปีที่แล้ว

    The actual solution is none of the above; the actual issue here is that we have a requirement here to have non-compile-time type-checking. The real solution, without pulling an external library like zod, is to combine runtime-type-checking with compile-time-type-casting. For example:
    ```typescript
    const access = (key: string) => {
    if (!Object.keys(myObj).includes(key)) {
    throw new Error(`Invalid key for myObj: ${key}`);
    }
    return myObj[key as keyof typeof myObj];
    };
    ```
    That said, as another commenter said, this is some batshit insane stuff for typescript. I know there's projects out there like zod and ts-reflect, but I really wish the TS devs would add to the core of typescript, optional runtime type structures. Something like this:
    ```typescript
    import "@total-typescript/ts-reset/array-includes";
    const access = (keyString: string) => {
    const key = typescript.toKeyType(keyString);
    // ^?: "a" | "b"
    return myObj[key]
    }
    ```
    They really seem against this idea but it's a massive, glaring hole in the whole system. Hell, even if we had a single typescript runtime function that just dumps the type information as a data structure, that would go a long way, then we could have a library like `clark` or something:
    ```typescript
    const myObjTypedef = typescript.dump();
    assert.intersects(myObjTypedef, {
    kind: "Object",
    keys: [ "a", "b" ]
    })
    const access = (key: string) => {
    return clark(myObj).indexPropertyViaString(key)
    }
    ```
    I dunno. It's a major problem with typescript that gets swept over too often

  • @rahulreticent5034
    @rahulreticent5034 ปีที่แล้ว

    Hi Matt Pocock
    I'm stuck with creating a type which determines the args types of callback function
    so while calling the callback function it should give type error while passing wrong arguments
    for eg :
    const main=(cb)=>{
    cb("abc", "232"); // not giving type mismatch error
    }
    function cb(a: number, b: number){
    return a+b
    }
    Thanks in advance

    • @mattpocockuk
      @mattpocockuk  ปีที่แล้ว +1

      mattpocock.com/discord is the best spot for this stuff

    • @eqprog
      @eqprog ปีที่แล้ว

      Check out the “Parameters” utility type. You can use it with a spread operator (ie something like function(…args: Parameters[]) or you can even index the different args of the function Parameters[0] to get a specific argument

  • @Endrju219
    @Endrju219 ปีที่แล้ว +1

    Isn't there a funky way to define `myObj` type as a Record intersected with the `typeof myObj`? For example with a mapped type? So that any string is a legal key returning some default value type, but `a` and `b` keys have a particular value type.

    • @mattpocockuk
      @mattpocockuk  ปีที่แล้ว +3

      It's actually pretty hard to do this, and might be impossible - because the index signature HAS to match up with any defined types.

    • @Endrju219
      @Endrju219 ปีที่แล้ว +1

      @@mattpocockuk thx! so **until that constraint is dropped**, my idea is only possible for a case where the type of the properties of `myObj` is the same as the value type defined in Record... which is basically just a Record 😄

    • @mattpocockuk
      @mattpocockuk  ปีที่แล้ว +2

      @@Endrju219 Exactly!

    • @lengors7327
      @lengors7327 ปีที่แล้ว

      Until you can exclude literal types from their respective general types, I don't see how you would be able to do this, tbh

    • @ApprendreSansNecessite
      @ApprendreSansNecessite ปีที่แล้ว +1

      @@mattpocockuk `{ [k: string]: string } & { a: number, b: number }` is valid TS. the properties `a` and `b` will be of type number and any supernumerary property will be of type `string`

  • @QwDragon
    @QwDragon ปีที่แล้ว +1

    I would've do this:
    const obj = {
     a: 1,
     b: 2,
    }
    function access(key: K): typeof obj[K & keyof typeof obj] | ([Exclude] extends [never] ? never : undefined) {
     return (obj as any)[key]
    }
    access("a") // number
    access("b") // number
    access("c") // undefined
    declare var str: string;
    access(str) // number | undefined
    declare var abx: 'a' | 'b' | 'x'
    access(abx) // number | undefined

    • @lengors7327
      @lengors7327 ปีที่แล้ว

      Why the wrap exclude in a array/tuple?

    • @QwDragon
      @QwDragon ปีที่แล้ว +2

      @@lengors7327 because you can't distribute never. It's the standard way to check never.

  • @adkuca
    @adkuca ปีที่แล้ว +2

    keyword "as" should have an alias "trustmebro"

  • @darenbaker4569
    @darenbaker4569 ปีที่แล้ว +1

    Why couldn't I have seem this 4 hours ago when I run into this problem 😂 anyway solved it using as constant on the object which seems to work, sure it will bite me at some point, but it's only a next13 pocket. Many thanks love your videos

  • @josipX
    @josipX ปีที่แล้ว +2

    Yet another BANGER

  • @Nabulio85
    @Nabulio85 ปีที่แล้ว

    Thank you very much.
    Great work.

  • @sergiigolembiovskyi1365
    @sergiigolembiovskyi1365 ปีที่แล้ว

    Hey Matt, thanks for your videos, it’s so simple explaining of so difficult understanding topics. BTW It will be cool to know your point of view on the following case: there are interfaces - one is base, and others are extended from it. Also, we have classes that implement all the interfaces. What is your suggestion to implement some generic method (typeOf) in the base class via which we can check what the actual interface of this instance is? I’m sure it must be interesting to most TS developers. Thanks in advance!
    interface IBaseComponent
    interface IComponent1 extends IBaseComponent
    interface IComponent2 extends IBaseComponent
    abstract class BaseComponent implements IBaseComponent
    {
    public abstract typeOf():this is T
    }
    class Component1 extends BaseComponent
    class Component2 extends BaseComponent
    //___________________________________
    const factory = new ComponentFactory();
    const component1 = factory.newComponent1(); // component1: IBaseComponent
    const component2 = factory.newComponent2(); // component2: IBaseComponent
    component1.typeOf // false
    component1.typeOf // true && component1 is IComponent1

    • @mattpocockuk
      @mattpocockuk  ปีที่แล้ว

      Interfaces disappear at runtime, so this is unlikely to work

  • @kylelambert__
    @kylelambert__ ปีที่แล้ว

    Love your videos, really great work. Could you possibly do a tutorial on how to create polymorphic types for a React box component. It seems since the release of Typescript v5, the old ways for handling these types don't work anymore. I've been banging my head against the keyboard for days trying to figure it out. Thanks for the content! :D

    • @mattpocockuk
      @mattpocockuk  ปีที่แล้ว +3

      This is coming in my Advanced React workshop! Though a YT video here would be great too.

    • @kylelambert__
      @kylelambert__ ปีที่แล้ว

      Amazing! Can't wait for this.

  • @dzdeathray
    @dzdeathray ปีที่แล้ว

    How are those solutions written? Is it just markdown in a code editor?

    • @mattpocockuk
      @mattpocockuk  ปีที่แล้ว

      Yeah it's markdown in a CMS

  • @Tazzad
    @Tazzad ปีที่แล้ว

    What about dynamic components in react with typescript?

    • @mattpocockuk
      @mattpocockuk  ปีที่แล้ว

      What kinds of dynamism are you thinking about?

    • @Tazzad
      @Tazzad ปีที่แล้ว

      @@mattpocockuk Say you recieve an object from a server that you need to show your end user. And the types could be Dynamic Text, Image, Video, TH-cam embed, PDF document, Audio etc. You could solve it with a switch case but that gets really messy really fast. Are there other ways you could solve it?

    • @mattpocockuk
      @mattpocockuk  ปีที่แล้ว

      @@Tazzad A big discriminated union

  • @ColinRichardson
    @ColinRichardson ปีที่แล้ว +7

    "TS things it's a number"... **Thinks**

  • @ahmedennab9745
    @ahmedennab9745 ปีที่แล้ว

    why not use as const?

    • @mattpocockuk
      @mattpocockuk  ปีที่แล้ว

      Because it's supposed to be dynamic - and as const is for creating static objects.

  • @TheRavageFang
    @TheRavageFang ปีที่แล้ว

    as const?

    • @mattpocockuk
      @mattpocockuk  ปีที่แล้ว

      Check out my other video on it

  • @mx-dvl
    @mx-dvl ปีที่แล้ว +1

    I’d take the opposite stance to this video and actually argue that dynamic objects should be this hard.
    I’d probably implement a simple `key in obj ? obj[key] : undefined` - but I think TS is correct in forcing you to make a decision, and future travellers will be thankful you were explicit about expectations

  • @karmandev
    @karmandev ปีที่แล้ว

    I thing you made a spelling mistake in the last example

  • @bronzekoala9141
    @bronzekoala9141 ปีที่แล้ว

    or - in this example - just
    const myMap = new Map([
    ["a", 1],
    ["b", 1],
    ])

  • @andreilucasgoncalves1416
    @andreilucasgoncalves1416 ปีที่แล้ว +2

    In the end all my ts problems are solved using "as any" and tests. Typescript does not replace tests and the mental effort to make all types correctly it's not worth most of the time

  • @chrisbirkenmaier2277
    @chrisbirkenmaier2277 ปีที่แล้ว

    Is there a way to (un)safely access the object with a unknown key, and to check if the result is defined? Like, ```if(!myObj.at(key)){return;} continue```. In other words, I know that I don't know if my key is a keyof my object, so I want to check to see if my object is defined at this key. Disabling 'noUncheckedIndexedAccess' or type-casting can't really be the only option, or?

  • @dkazmer2
    @dkazmer2 ปีที่แล้ว

    Typo 😉 in the comment of your last example: "TS things..."

  • @simpingsyndrome
    @simpingsyndrome ปีที่แล้ว

    typecool

  • @samarbid13
    @samarbid13 ปีที่แล้ว

    Unpopular opinion: I think AI or Copilot in the editor should handle TS. Developers shouldn't sweat over these types. 😅 It feels like we spend more time than the actual perks we get. Anyone else feel this way? And oh, anyone know a killer VSCode extension for this type madness? 👀🔧

  • @xushenxin
    @xushenxin ปีที่แล้ว +5

    I think it is waste of time. I would rather spend the time on making sure the features for business requirement.

    • @FlyingPenguino
      @FlyingPenguino ปีที่แล้ว +3

      Good luck

    • @DarkSwordsman
      @DarkSwordsman ปีที่แล้ว +1

      What is a waste of time?

    • @carlogustavovalenzuelazepe5774
      @carlogustavovalenzuelazepe5774 ปีที่แล้ว +1

      some of these solutions make the code work for years, the line between a simple yet brilliant solution and overenginnering things is thin I guess