The bug that's a feature in ComfyUI - batching and Ksampler noise!
ฝัง
- เผยแพร่เมื่อ 14 ก.พ. 2024
- Wouldn't it be nice if you could break down your comfyui workflow into two parts, so you can 'pick' the images you prefer for postprocessing using an image picker? Well, you can't. Here's why. / discord
🤗Help keep this channel brutally honest: ko-fi.com/stephantual
▬ LINKS REFERENCED ▬▬▬▬▬▬▬▬▬▬▬▬
github.com/chrisgoringe/cg-im...
▬ SOCIALS/CONTACT/HIRE ▬▬▬▬▬▬▬▬▬▬▬▬
Discord: / discord
All Socials: linktr.ee/stephantual
Hire Actual Aliens: www.ursium.ai/ - วิทยาศาสตร์และเทคโนโลยี
I don't really think it's a bug though, just something to be aware of. If you pass a batch to a ksampler and every image receives the exact same random noise at each step, you will get a batch of the same image, so of course we want each image in a batch to follow a different diffusion path. This is implicit when batching because the RNG gives you different results when you ask for a larger random tensor vs a small one even with the same seed. This also means that if you want to recreate the same image, you also have to recreate the whole batch with the same seed. You can still use an image chooser, but only let through one image (or a fixed number of images) at a time, which will ensure the workflow after the chooser is deterministic.
sadly I discovered this in a harder way, a month ago I was doing 16 batch images per queue (+10 minutes run time) looking for good results and saving the seed numbers to be used in later processes, then I discovered that the 16 images got the same seed and you need to run the whole 16 batch queue with batch selector node if you want to upscale one image of them
I tried using a lower batch number when I was targeting the second batch image, but it didn't work, cuz changing the batch number will change all the results
I think they should fix this by making Comfyui generate a unique random seed number for each image in the batch
Oh dang I hadn't thought of that possibility, you're absolutely right. I hope they change it, too, especially for people using this for work, where determinism is key. Thank you for sharing your experience! 👽
Could you please post a link to the bug report?
You got it! Here you go: github.com/comfyanonymous/ComfyUI/issues/2799
Just between you and me (and 8 billion youtube viewers) - I believe there are some deep seated emotions about this 'feature' :)
Thanks! @@stephantual
Good find, if you use the basic SD clip text encoders instead of the sdxl ones does the same difference also occur?
Yes - i also tried to pass ----deterministic to the command line, no dice. Also tried to switch the ksamplers to the ones from inspire pack, same outcome. I'm afraid there's no fix - and it's a 'hot topic' amongst the contributers to the comfy repo :)
What a extension allow you to see extension name above every custom node? and what extension allow you to see gpu load too. Looks really useful.
oh i found (accidentally). this is in comfyui manager - badge dropdown menu.
Yup and crystools for the monitor - all in the workflow :)
I visited your youtube channel, your videos are awesome. Your video SEO errors. Your channel is not growing at all. I offer you SEO and monetization of your channel. If you do SEO, your video will get lifetime views.
Aliens don't need SEO, because they can't handle money due to their tentacle appendage. It's very sad to watch them try to fold the 500$ bills we get from TH-cam every day. Makes me cry a little deep inside 😢