Clean code challenge - Silicon Valley Season 5, Ep6 🚀
ฝัง
- เผยแพร่เมื่อ 26 ก.ย. 2024
- 🚀🚀🚀 Become ELON MUSK playing most HARDCORE iOS mobile GAME: saviorx.com ! 🚀🚀🚀
#saviorx #mobilegame #unity3d
Nothing puts the fear of God into a programmer like the inevitable code review. This is when a group of people analyze your code for errors and shortcuts and violations of standard operating procedure like using spaces instead of tabs. I once worked at a Wall Street joint where our code review was like American Idol auditions. We had a panel of reviewers made up of my boss, the COO, and the CFO. They were ruthless. I would have to fill out paperwork describing my feature/fix, project my code on the conference room screen, and execute it while explaining my workflow. The slightest violation sent me back to the drawing board while my team members snickered nervously. I still have nightmares about this particular panel. My soul review at the Pearly Gates will be less terrifying.
Thankfully, Dinesh and Gilfoyle’s code will be observed by a special prosecutor - I mean reviewer - because they’re senior management, thereby saving them the embarrassment of a public flogging. However, Dinesh wants a public hearing, if only to prove that his code is superior to Gilfoyle’s. Jared is against this for a valid reason. “A little cocksmanship was okay when we were a small company,” he tells them, “but the coders need to see you guys as equally competent leaders.” Dinesh can’t handle not knowing if he’s superior, so he hounds Danny the Code Review Guy relentlessly until he reveals Dinesh was better! Danny asks Dinesh not to tell anyone. Of course, Dinesh tells the entire office.
The second someone else enters into Dinesh and Gilfoye's relationship they unite. I love it.
I do wish the engineer from season one was there more often, she was the perfect balance.
Clean Code does not just mean having less Errors by the way
It means having fewer errors.
@@ettiennepieterse371 no it means writing a code using the latest frameworks and technologies with best coding practices in mind. A tight code without any unnecessary extra coding is a clean code
@@saqlainalvi5485 It doesn't have to be the latest frameworks but everything else you said is right.
@@Aspectalice Yes brother. But a programmer should atleast know the basics of every new framework that comes out for his/her favorite language. But yeah you are right it's not necessary.
Note: i forgot to mention. Clean code also involves managing complexity through oop.
@@saqlainalvi5485 what are you talking about? Not everything is object oriented
Dinesh's pull requests must be brutal
What does that mean
@@aheathcliff7227 A "pull request" is when you submit a change to the existing codebase. One or more of your colleagues will look at your changes and either approve them or ask for more changes before the code is "merged" into the main codebase. The more changes they ask for, and the harsher their comments are, the more "brutal" the pull request is.
@@ticallionz I never understood why code review comments would need to be harsh, it merely shows the insecurity and egotism of the reviewer, much more than the competency of the submitter.
Also there'd be so many new changes to review since I'd imagine Dinesh doesn't push his code in small chunks.
@@ccriztoff what the fuck is your problem
The real winner here is Jared (and Richard) who told them to layoff each other, because they're senior management now. He's proven right in the end when the engineers band together to make fun of 'senior management'.
You mean Donald
@@francisconicolau8528 not Donald, Other Jared. OJ for short
pfp 💀
Nothing more devastating than Gilfoyle's monotone delivery of soul-crushing news 🤣
as a programmer they must've been really good friends for them to meme each other like that in a professional workspace
They've been coworkers, housemates, and rivals from before this company was even a company. Then they both joined as founding members, and now they've got a team of 46 engineers reporting to them. So yeah, good friends is pretty accurate.
every office has one Dinesh and Dany
Wait is that a racist joke or not
i wish i made enough money to relate to this joke
Fix a Fix yep its rly racist don’t read it
But what every office needs is a Gilfoyle and a hairy Arab who can Chortle his balls
This has nothing to do with “clean code”, clean code refers to a codebases readability, you can have clean code with a lot of bugs and ugly code with no bugs
Correct
I think they’re just trying to make it easier to understand. “Error” is one word and easier to write into this scene than “code with readability”.
Yessirr
properly refactored and debugged code.
eh
-How's the code been going?
-T minus Dinesh.
Silicon Valley is my comfort show, I wish it was still on
Same :(
It finish at the right time... after 6 or 7 season shows start to decay
Just rewatch it
"I have to fire Danny" 😂😂
Do you know what dinesh says after that? I can't quite make it out over the music.
@@quinndirks5653 "I'll ask Richard" 😅😅
Jyothir ganesh thought it was “afterwards”
OH, I thought he said "I have to fight Danny" haha
Danny was the human, who ate the tortoise and the hair after the race.
hare
No, he actually ate the hair
@@TooDamnFishy Tortoises don't have hair.
@ or...do they ?
Dun dun dunnnn
@@night00glider no they don't, they are not mammals
With respect to Dinesh, Gilfoyle is so arrogant that I doubt he allows bugs live in his code.
What
But that's the thing about coding. When you write a very complex code, even small tiny things can cause bugs. That's why even companies like apple Facebook and Google who literally have billions of dollars still end up with bugs.
This comment makes no sense
Yea, that's not possible
@@MangoMotors I mean you are somewhat correct in the sense that bugs will occur, but they literally have hour-long debug sessions or just use something called checkpoint testing where all valuable data is relayed after a certain section of code to the console for analysis. If there is an error they know where it is and if there isn't the code is ready to be peer-reviewed again. Most "bugs" come from human logic error more so than syntactic.
I had it when "Gabe" says , "Guys, Nononono, remember, we talked about this." Seemed like he was giving advice to Jim and Dwight lol 😂😂
@1:57 Gilfoyle slips a secret smile and coyly stows it away
Private review is stupid. Senior staff should be subject to the same standards as everyone else publicly
Better yet, hanging people out to dry when they make mistakes is counter productive. You don't get more productive by being shamed, you get more productive by being taught.
Wanooknox also we’re all humans we all make mistakes.
@@Wanooknox Yes. And this is actually used in top tech companies like Google, Facebook and etc...
In the end it doesn't matter, all code is committed to the same repository, and all commits are accessible by everyone who has access to the code.
Easy to see how made mistakes, how they got fixed, etc.
And ideally anyway, your branch would not get merged until every PR is reviewed and approved. And all PRs are public as well.
So this whole "private review" is basically useless and bullshit.
@@Wanooknox It is productive and you're not supposed to be shamed it's supposed to set an example so other devs won't encounter the same mistakes. While you can get tips from your fellow colleagues and not just the ones reviewing your codes.
I love Dinesh and Gilfoyle. I've said it 1,000 times but the writing on this show complemented by their delivery is the most under rated. Of all time possibly.
Mike Judge is a fucking genius
3:30 he should have made A Bug's Life joke
that would make his joke good
Dinesh: Less errors..
Stannis 'Gilfoyle' Baratheon : Fewer..
Gilfoyle plays magic lmao
Gilfoyle is a key here and in whole
These two guys are now marvel actors
“Nothing puts the fear of god into a programmer like the inevitable code review” Jesus Christ well I guess that’s one thing to look forward to when I get a job in coding
if you approche it right, you can grow a great deal from code and design reviews.
Reviews are actually the best way to learn and improve. Both reviewing and being reviewed
I actually like code review
... its really fucking easy just follow the rules. The best reviews are the ones where you learn a new way to look at things.
Its also not just about bugs, you learn to do things more efficiently from people who have years experience.
"did his code have less errors than mine?" - you can hear non-programmers wrote this script.
That MisSteak line was actually pretty good though
"I see, fun at my expense" lol
“Laugh it up GILF”. Hahaha
" i m not gonna beg "
"PLEASE"
"PLEASE"
"PLEASE"
Ohhh. The guy is literally like one of my old colleagues. So noisy in that high pitch voice. And taking credits for everything
My supervisor was that high-pitched guy at my old company. Guy made me want to cut my ears off every time he called my name
“You just have to swear not to tell everyone”
Dinesh: “I swear”
Everyone, everyone... my code is better than......
I relate at an uncomfortable level to Dinesh repeatedly practicing the delivery and phrasing of his joke at 3:23
Dude this show is my life.
Lmao how jarad walks over and stops the loud gong
Never knew The Hound is a coder. What a cool guy.
haha we're all laughing at you, gilfoyle - makes me laugh every time
Three way fight. The only way to coexist 'peacefully'
So danny got them both ??
Pretty much
I don’t really see how gilfoyle saw that as a “victory”, he just predicted the obvious basically
The Type O joke is low key 🤣 funny
2:37 Lmao that coffee mug
Nobody:
Dinesh: I'm the fucking Tortoise!
00:54 if you saw it give yourself a punch.
haha they actually put "made in china" song lol.
These two are like a married couple with 20+ or so years of marriage behind them...they are comfortable enough to abuse, tease, make derogatory comments to each other and yet they are the best duo in tge series.
Wonder what those who neither work in tech nor are familiar with it thin of this.
I must admit, while I used to be intimidated by PRs early on, now they either reinforce my good habits or address my bad ones. So they're win-wins all around.
And yes, especially with bigger PRs reviewed by more people, there's a nice sense of satisfaction when it's approved on the first pass. Like, BOOM! Nailed it!
4:42 That pentagram lol
2:59 "I hope the book you're reading is for work"
Book: "Coders at work"
@@user-dp5fq4vc8m thanks
I have so much sympathy for Dinesh, he tries so hard. 😂
Higher Brothers 👌🏾👌🏾👌🏾👌🏾
MISTAKE HOUSE! haha
i know it’s a hard time with all this covid shit but always..always Tabs over spaces.
oh hell no
@@KohenChia This is not meant for people that uses Microsoft Word as their IDE
Visual Studio Code with plugins for language syntax helper s installed changed my life.
Pycharm is also pretty good at that.
I'm the f***in' tortoise.
"Everyone is laughing" 😂
gilfoyle watches GOT. uses FEWER from Baratheon🤣
Actually Stannis used it because it's correct. Same reason Gil does.
@@BastardOfTheNorth Baratheon is Stannis' last name😂 if you watched the show, I dont have to clarify which Baratheon.
@@tarifadib I am aware of that.
Danny, the hr lady,and John are the only 3 people who won against Gilfoyle(HR lady managed to actually annoy Gilfoyle by being right,to an extent).Dinesh never beat Gilfoyle but he was the only person who could keep up with him.
I love how Gilfoyle can troll Dinesh into a scene
What if San Francisco people didn't saw this as a comedy series and actually think this is the way they should behave at work.
Not sure if I'd quit or give that one dude swirlies every time he opened his goddamned mouth.
1:08 Gabe is back.
dinesh and gilfoye are like two sibling always fighting each other but the moment someone hurt one of them their blood gets thicker than water
George eRRor Martin
What kind of senior managers are these?
I have no idea
Senior management that can function is still code.
Gilfoyle == JonathanCoulton + RonSwanson
i am currently learning how to be a programmer. and everytime i see these guys code that fast intimidates me.
dmr0718able it's a show. No one writes meaningful code like that.
You should be spending a majority of your time designing and analyzing your program, not much time actually coding and then quite a bit of time debugging
Cut and paste.
Just copy n paste n adapt, no one write clean code these day lol
@iii i have seen people code that fast but they ended up being great. All became hackers and got caught
@Colten DeYoung git add seppuku.gif
commit -m "RIP"
I loved how this show always wrote Gilfoyle & Dinesh to have a in work feud as who is the better coder. Yet like the episode where they go to Double A warehouse & they see the calculation of Blaine's pre skecthes & they start SWATTING (code)aka insults like fuck Gina, let Blaine die etc.
Ixalan is a Magic: The Gathering expansion block
They are the definition of a married couple
"Gilf"
The Jackrabbit Always Wins
Dinesh my man... Type O is the type you go to when you need blood : (
One of the best series I have ever watched
Same here 🤣
*bugs lightgear*
Damn. Gilfoyle is just a Rick from Rick and Morty. But a 32bit
Cute how Jared stills the gong
They should have used Object Calisthenics... They wouldn't have finished
I mean, I need to write it: there is no way someone found bugs/errors in review (unless code was super bad). Review is done to improve style. If you want identify bugs you need testing. This is the only way. Yeah, I don't have friends
A successful funded startup and they don’t have a proper CI/CD pipeline 🙃
Gilfoyle has good taste tho, ixalan was a good expansion
despite I disagree about Ixalan, as a fellow MTG player I think your comment is very under appreciated
I can't wait to be working in this field. Got 3 class to go
You are up for a massive disappointment if you expect this kind of environment.
@@fofopads4450 what do you mean?
@@dougsam6341 how is it
Man, I would live in their world, as Russ Hanneman. Tres commas!!!
lol.
Wait thats Gabe..what is Gabe dokng there..
Probably telling people to shut up about the sun😊
I hope I never have to work with a Danny.
Damn the Higher Brothers got a song used in silicon valley
2:26 gilfoyle turns around and says less errors lol
It took me 7 minutes to realize the video isn't about clean code at all
3:20 jing yang smart fredge
ChatGPT enters room.
Private review, I'm a senior engineer and no one reviews my code except me :D
He really is the cool cousin
Consider the tortoise- Dinesh
Love the range of emotions portrayed by Kumail in this clip, seen by pressing the following keys:
0: some sort of sexy coding face 2: machismo intensity, 3: worry/pleading, 4: gloating, 5: pain and acceptance, 6: faux concern amidst further gloating, 7: joking with a hint of approval-seeking, 8: shock, 9: confusion
Even if his character was fairly Flanderized by this point, Kumail's a pleasure to watch.
Wait, would they not just run the code in Jenkins? Doing the build and integration tests thus finding the bugs anyway? It's the inaccuracies like this that take away from the show
Unit/integration tests cannot prove the absence of bugs, that is, 100% pass rate and coverage do not mean your code is bug-free.
@@thomasip9938 yes but also code reviewing using eyeballs doesnt either. They should be code reviewing then running it through automated builds. Simply getting one person to reviewing all their code is bullshit.
Is Dinesh using a Monokai theme? I can't tell.
an entire tv series about reddittors
A few comments out there "THATS NOT WHAT CLEAN CODE MEANS" -- That's the youtuber's fault. The title of this video is the only time the words "Clean Code" were used. The actual clip NEVER said anything about Clean Code.
5:06 teamwork
It's not about clean code, it's about clear code
I’m not gonna beg! I’m not gonna beg! … Please please pleassse please please!
the interesting part is that you can't see them testing the code, just pushing and yeah, it's done
George Error Martin 😂😂😂
George eRRor Martin is a must to read book