I HAD to fix this immediately // Code Review

แชร์
ฝัง
  • เผยแพร่เมื่อ 30 พ.ย. 2024

ความคิดเห็น • 91

  • @TheCherno
    @TheCherno  10 หลายเดือนก่อน +15

    Thanks for watching! What did you think of me fixing stuff during code reviews?
    Also don’t forget you can try everything Brilliant has to offer-free-for a full 30 days, visit brilliant.org/TheCherno. The first 200 of you will get 20% off Brilliant’s annual premium subscription!

    • @АндрійКучеренко-с4ф
      @АндрійКучеренко-с4ф 10 หลายเดือนก่อน

      Ctrl+T opens VS "Code Search" window, there you can search over files or types using same fuzzy patterns as in VS Assist. Decent replacement for majority of use cases.

    • @nerdastics3987
      @nerdastics3987 10 หลายเดือนก่อน

      c++ is such a complex and incredible language that even people who've been doing it for 25+ years are still learning more every day (i have a friend like that). It's beautiful

    • @toolazytobeoriginal4587
      @toolazytobeoriginal4587 10 หลายเดือนก่อน +1

      I enjoyed this video. Very helpful. Btw can you add this to the code review playlist?

    • @sumikomei
      @sumikomei 10 หลายเดือนก่อน

      I really liked seeing you fixing stuff that you felt necessary or important, there's quite a lot of insight to be had from that I feel.

    • @blakasmurf
      @blakasmurf 10 หลายเดือนก่อน

      KER-ZUH

  • @denizberkinmis
    @denizberkinmis 10 หลายเดือนก่อน +64

    I HAD to see this immediately! // Watching Code Review.

  • @jell0goeswiggle
    @jell0goeswiggle 10 หลายเดือนก่อน +125

    Cherno: "You have to be patient and read the comments. You'll definitely learn something."
    Also Cherno: Completely missing the comments explaining the hover any window argument, followed by minutes of trial and error.

    • @TheCherno
      @TheCherno  10 หลายเดือนก่อน +52

      Was waiting for someone to notice! 😅

    • @itzdabbzz
      @itzdabbzz 10 หลายเดือนก่อน +4

      @@TheCherno It truly happens to the best of us... We just get so side-tracked.

    • @Турист-д1о
      @Турист-д1о 10 หลายเดือนก่อน

      @@TheCherno Good afternoon, I am a beginner programmer and didn’t know where to write questions.
      1) Please tell me, in order to get the source code of Hazel Engine and get the source code of the latest version of Hazel Engine, do I need to buy a Supporter III subscription for $10?
      2) In which Hazel Engine programming languages ​​can you program and create games?
      3) Does the engine have a drawing like in Unreal Engine?
      4) Is it possible to transfer a model from blender to Hazel Engine?

    • @TheCherno
      @TheCherno  10 หลายเดือนก่อน +1

      @@Турист-д1о
      1) Yes
      2) C# to make games usually, though you can also use C++. Engine is written in C++
      3) What do you mean by "have a drawing"? It's got a UI and an editor similar to Unreal Engine if that's what you mean
      4) Yes

    • @gaagey
      @gaagey 10 หลายเดือนก่อน +1

      Just 5 hours of debugging may save you 5 minutes of reading documentation.

  • @gabrielwhite9881
    @gabrielwhite9881 10 หลายเดือนก่อน +6

    its really nice to see u improving code, because it helps a lot to see the actual code about what u explain, what could be improved. :)

  • @beefy___
    @beefy___ 10 หลายเดือนก่อน +4

    24:15 Windows has that builtin. The keybind is WINKEY + V

  • @SwedishviKingohnoes
    @SwedishviKingohnoes 10 หลายเดือนก่อน +2

    Actually did like this format! It shows how you think about UX and how you learn about a codebase/library.

  • @simonluner8093
    @simonluner8093 10 หลายเดือนก่อน +13

    Ctrl + Shift + V for clipboard history is MVP advise

    • @fuj1n
      @fuj1n 10 หลายเดือนก่อน +2

      If you use a modern version of Windows (10 or 11), there's also the OS-wide Windows + V, it has to be enabled, but if you press it whilst it is disabled, it'll prompt you to enable it.

    • @kevinscales
      @kevinscales 6 หลายเดือนก่อน

      @@fuj1n There are some things I would rather windows forgets I copied...

    • @fuj1n
      @fuj1n 6 หลายเดือนก่อน

      @@kevinscales Lucky you, there's a clear button

    • @DenshinIshin
      @DenshinIshin 4 หลายเดือนก่อน

      @@fuj1n That things is great. I use it all the time, and when I see for how long there was clipboard manager and history in other DE/WM on other OS, I wonder why it took as much time for window to implement something as simple as this. It's a life and time saver.

  • @Eduard_0110
    @Eduard_0110 10 หลายเดือนก่อน +4

    If you press E then you can lock the camera movement, press E again and you will unlock the camera movement

  • @digital_hoboz
    @digital_hoboz 10 หลายเดือนก่อน +2

    With Jetbrain products you can put breakpoints on different statements on the same line which is very useful in lambdas.
    I don't know why VS doesn't have it yet.

  • @bluesillybeard
    @bluesillybeard 10 หลายเดือนก่อน +6

    Cherno: writes code to release the mouse, when the literal next line of code does exactly that when pressing E

    • @blakasmurf
      @blakasmurf 10 หลายเดือนก่อน +1

      He had his KER-ZUH in the wrong place! 😉

  • @dct4890
    @dct4890 10 หลายเดือนก่อน +3

    Great job. Learned a lot about perspective as well as code. Thanks for jump starting my brain from holiday food coma back to project immersion.

  • @resongeo2743
    @resongeo2743 10 หลายเดือนก่อน +3

    Great video! And the engine programming series sounds great!

  • @HaydenLikeHey
    @HaydenLikeHey 10 หลายเดือนก่อน +2

    Much prefer the videos with code editing portion, personally

  • @Beatsbasteln
    @Beatsbasteln 10 หลายเดือนก่อน

    your skills at navigating someone else's code base are admiring

  • @arnedebeer
    @arnedebeer 10 หลายเดือนก่อน +2

    Happy new year as well! Nice review. How's it going with the ray tracing series that you were making? 🙈

  • @scottwalker4619
    @scottwalker4619 10 หลายเดือนก่อน +4

    Every Jetbrains IDE has the Visual Assist feature. As a C# developer, I could never go back to Visual Studio after using Rider 🙂

    • @gardian06_85
      @gardian06_85 10 หลายเดือนก่อน

      at some point the IDE is a crutch from knowing the code base, or how things function. Rider also has code generation included, sure it can speed things up, but can quickly hide the "why?"
      with all the functionality VS has added either from Rider/Visual Assist it just becomes paying an additional $100+ (technically an addition $50 at VS pro/enterprise) monthly sub for a auto fill copilot which also does some really stupid stuff at times that requires real knowledge to know when it is doing stupid stuff.

    • @fuj1n
      @fuj1n 10 หลายเดือนก่อน

      @@gardian06_85 You can just not use that feature, I know I don't
      JetBrains products provide a streamlined, unified interface for each of the languages they support. You learn the IDE once and you can bounce around all of the supported languages. I've also found it much more performant than VS. They separate their IDEs for each language/problem domain, so you are not bogged down by the extra stuff if you only care about C++ or C# for example.

    • @scottwalker4619
      @scottwalker4619 10 หลายเดือนก่อน

      @@gardian06_85
      I disagree with it becoming a crutch on knowing the code base as well. Learning a code base takes time and being able to navigate around it effortlessly surely only helps that learning process?
      The rider pricing is only around 15 a month btw so I don’t know where you’re getting “100+” from (apologies if I misread that).
      The AI side is obviously a completely different discussion but I’ve found it has sped up my workflow. It’s still down to the developer to see if it’s done something stupid and test whatever it’s written.

    • @digital_hoboz
      @digital_hoboz 10 หลายเดือนก่อน

      ​@@gardian06_85 you are just wrong. Rider/Resharper and copilot are not comparable. The fact that you mention them in the same sentence shows you have no idea what you're talking about.

    • @gardian06_85
      @gardian06_85 10 หลายเดือนก่อน +1

      @@scottwalker4619 alright I give you the pricing for professional (when researching the pricing for personal use Jetbrain defaults to yearly, and Microsoft only 'shows' monthly), but then Jetbrain products only have a "free" price for education, so Visual Studio does have an option for nearly the entire product until you/your company actually needs it with the "Community"; which is effectively used as release candidates of the Pro-version.
      I call Rider a crutch as one of the only selling points it really has is the built-in co-pilot as everything else boils down to "loading times", "intellisense sometimes not knowing things", (these can be adjusted through patches/updates) and "navigation experience" (which is subjective and can be learned much like a persons first IDE experience would need to be learned)
      I have the most experience with JetBrain products on the C++ side (where they have 4 technically 5 products for C++ similar to how they have 3 different products targeting C# where the biggest differences are see above) and the number of times I have still had to go in and manually add an `#include` when that is one of the main selling points to auto add includes (these are `#include` meaning they are already in the Solution parser so it should be understood by their built-in co-pilot) and this is one of the only real selling points of their products, so as an independent that does not meat the yearly pricing threshold for VS Pro why even spend $15/month for something that doesn't even do the biggest selling point without babysitting.
      I focus on the co-pilot because it is the only real selling point of the products. These tools can help people that already know a lot about the code-base and the dependencies work faster, but to newer developers it is a crutch where "the system will just do it for me" and when it doesn't then that user has to figure out why it doesn't work because it was just supposed to be 'magically there'. these type tools are tricky because they are always talked about as "they will help everyone with the boiler-plate stuff of the stuff that doesn't really matter" when if the user gets accustomed to using the tool and having it do the things for them; they might be blind-sided when say during a physical stand-up they are called to a white-board, or during a code-interview they are asked to use a simple web-IDE that doesn't have some co-pilot and they expect you not necessarily to solve the problem but to work through it (when some of the co-pilots you start writing `class map {` and it will just suggest 50+ lines to accept, comments optional)

  • @madeso
    @madeso 9 หลายเดือนก่อน

    I'm pretty sure you can place a breakpoint on the break by placing your cursor there and hitting f9/"add breakpoint"

  • @ilmanti
    @ilmanti 10 หลายเดือนก่อน +2

    ctrl+shift+v is going to change my life. thank you.

  • @spider853
    @spider853 4 หลายเดือนก่อน

    Was there an E shortcut to release the mouse from controlling the view? )

  • @miladhakimi3495
    @miladhakimi3495 10 หลายเดือนก่อน

    Great video Cherno. Thanks!

  • @mobslicer1529
    @mobslicer1529 10 หลายเดือนก่อน

    happy new year

  • @unkgames-abdullahali4048
    @unkgames-abdullahali4048 10 หลายเดือนก่อน +2

    If he wants to expand this engine to multiplatform engine he should make a building system that includes all APIs then simply switch between them for each platform

  • @velho6298
    @velho6298 10 หลายเดือนก่อน

    I suppose you don't have to necessarily copy the field of the structure because you have the option to list all references in Visual Studio.

  • @tmvkrpxl0135
    @tmvkrpxl0135 10 หลายเดือนก่อน

    Funny thing is mouse problem you mention at the beginning is the exact problem Minecraft has, it pauses the game to mitigate that but that often fails in debug mode

    • @Kaleidio
      @Kaleidio 10 หลายเดือนก่อน

      this bug was patched ages ago in Java Edition.

    • @tmvkrpxl0135
      @tmvkrpxl0135 10 หลายเดือนก่อน

      @@Kaleidio It happened to me on 1.20.4 while developing mod. Break point in debug mode mess up their logic.

  • @GoldmvHjsnce
    @GoldmvHjsnce 10 หลายเดือนก่อน

    Is there a precompiled version of the engine that we can use ?

    • @Eduard_0110
      @Eduard_0110 10 หลายเดือนก่อน +1

      I'll add one soon

    • @Eduard_0110
      @Eduard_0110 10 หลายเดือนก่อน

      added in the release

    • @GoldmvHjsnce
      @GoldmvHjsnce 10 หลายเดือนก่อน

      @@Eduard_0110 🥰

  • @magnuswootton6181
    @magnuswootton6181 10 หลายเดือนก่อน

    theres how to do a path tracer, only runs on top level gpu. next well show shadow correction. (runs on xt!!!) hehe

  • @DeepiMeows
    @DeepiMeows 10 หลายเดือนก่อน +1

    I asked Chat GPT to give me a link to youtube tutorial that will teach me coding you poped up

  • @furyzenblade3558
    @furyzenblade3558 10 หลายเดือนก่อน

    2:45 Which video is he referring to? I cant see it

    • @Eduard_0110
      @Eduard_0110 10 หลายเดือนก่อน +1

      Just the previous video on hid channel

    • @furyzenblade3558
      @furyzenblade3558 10 หลายเดือนก่อน

      @@Eduard_0110 thank you!

  • @ZephyrCheez
    @ZephyrCheez 10 หลายเดือนก่อน

    Hey, what is your opinion on Rust in the future of game development?

  • @whtvr1520
    @whtvr1520 10 หลายเดือนก่อน

    was cool

  • @dj10schannel
    @dj10schannel 10 หลายเดือนก่อน

    Lol chirno teaching main lesson everyone need to know "learn to read"

  • @kotofyt
    @kotofyt 10 หลายเดือนก่อน

    Watching this while waiting for goblins game jam

  • @Stroopwafe1
    @Stroopwafe1 10 หลายเดือนก่อน +4

    Cherno: "You have to be patient and read the comments. You'll definitely learn something."
    Also Cherno: Not reading the readme or the comments explaining the keybindings for disabling camera movement.
    I'm sorry but every time you mentioned something about it, it was just very frustrating

  • @Spongman
    @Spongman 10 หลายเดือนก่อน

    chatgpt "how to capture the mouse in opengl"

  • @Astralklinge
    @Astralklinge 10 หลายเดือนก่อน +2

    im just learning c++ do you think its worth it?

    • @PixelThorn
      @PixelThorn 10 หลายเดือนก่อน +1

      Yes

  • @hachimibouizegarene9544
    @hachimibouizegarene9544 9 หลายเดือนก่อน

    big boss

  • @enriquebenedicto9429
    @enriquebenedicto9429 10 หลายเดือนก่อน

    I'm puzzled by a completely off-topic piece of code seen a few times in the video. It's about the "not equal" sign. Usually, in C++, they're written as "!=". However, I've noticed them being written as "=" with a bar across. How is that possible?? I wouldn't think the compiler would process that special character as being the same as "!=". Very puzzled by that.

    • @traister101
      @traister101 5 หลายเดือนก่อน

      It's called a ligature. It's two separate characters ! and = which get merged together and displayed as ≠

    • @enriquebenedicto9429
      @enriquebenedicto9429 5 หลายเดือนก่อน

      @@traister101 yeah. I have since found out. Was so weird the first time I saw that.
      Thanks

  • @Godot-Game-Dev
    @Godot-Game-Dev 10 หลายเดือนก่อน

    no way I watched this 7 min after it was published XD

  • @zoakz8347
    @zoakz8347 10 หลายเดือนก่อน

    its 3am....

  • @smokinglife8980
    @smokinglife8980 10 หลายเดือนก่อน +5

    imguiio has a wantstocapture method

  • @gsestream
    @gsestream 10 หลายเดือนก่อน

    well use a mouse trap as usual >.> hmm no in productivity editors no capture, never. rtfm hurts my head. if you are making an editor for a game engine learn not to capture the mouse never. mouse drag while clicked is the simplest for productivity applications gui. chill you dont have to know your own code even. relax. ownership is hard burden work.

    • @gsestream
      @gsestream 10 หลายเดือนก่อน

      I hate build systems! every one of them, especially gradle and its compatibility matrices. well if the build system is what prevents code from compiling, the enemy is clear.

  • @MrTehkaiser
    @MrTehkaiser 10 หลายเดือนก่อน

    Chero is a true master baiter.