Hi Gary, sick shit! but is the api still working? I'm not able to navigate to the page of the api and not able to fetch any data.. getting a 403 response gr thijs
I've not checked recently but no one else has mentioned it. 403 means there's some kind of problem with your creds. You set up auth the same way as me?
As for a fresh graduate programmer this course helped me A LOT while solving the technical task required for job application. Thank you, learned so many new things while double watching this course
Thank you so much for this high quality content. I learned so much from this video and appreciate how you explained all the details. After I failed with Symfony 5.2 - I had a dependency version conflict with DAMA/doctrine ... - I was able to recode everything with Symfony 5.3 nicely.
Hmm I have a stupid question maybe :) Should tests belong in the main repo ? On the dev branch ? Or just keep them locally on my machine ? Because eventually what's on the dev branch will eventually be merged in the production and deployed.
Wow ! I didn't think that in-memory DB can be used for unit tests , thank you ! It indeed makes sense, because these DB are temporary, and each test have its own DB... This will avoid me to use mock objects to use the EntityManager then 🙂!
I'm traying to do it, but in the minute 13:17 get this error: 1) App\Tests\StockTest::a_stock_record_can_be_created_in_the_database Doctrine\ORM\Mapping\MappingException: Class "App\Entity\Stock" is not a valid entity or mapped super class. Some idea?
In the price tests, you should test for assertIsNumeric because sometimes it sends back whole dollar amounts with no cents (and it does't display xx.00) when that happens, the test will fail.
Hey Gary, thanks for the video. I am using symfony v6.2 and so far followed everything. in 13:10 of the video I get this error: There was 1 error: 1) App\Tests\StockTest::a_stock_record_can_be_created_in_db Error: Call to a member function persist() on null C:\wamp64\www\phpunit\tests\StockTest.php:45 Any idea what might be the cause?
Yes..looks like you don't have an entity manager...you're getting null instead. Dump out your entity manager using dd() and see what you get then work backwards to figure out where you went wrong with it.
Thanks for the video Gary, but i got an issue at 42min in the video. I want to test YahooFinanceApiClientTest in integration folder, and i got 'Undefined property: stdClass::$price' i think its due this line off code: $stockProfile = json_decode($response->getContent())->price; any idea's? Thx
@@GaryClarkeTech never used sqlite before and was getting a DriverException from Doctrine when running the first test, just sharing in case someone encounters the same problem. Fixed it by installing sqlite and uncommenting the sqlite lines in /etc/php/php.ini Thinking that maybe starting the tutorials by creating the docker containers in which to work would eliminate this kind of local dependency issues for viewers.
I am using a newer version of Symfony. All my tests are fine, but when I run the command, I get a "syntax error" reported from JsonDecode.php. However, there is no other information about what is causing this. I have not debugged yet (I have the hardest time getting xdebug to work with cli apps, but I will get there). Curious if anyone else has come across this error or has any ideas?
Excellent tutorial, but you have extracted the finance API to an interface which completely dependent on Yahoo API, the fetch method should not have any arguments bonded to a specific API, maybe the next API does not require the symbol and region.
Great tutorial! Thanks. I am running into an issue though. Somehow it will not set that its running on the test environment. dd($kernel->getEnvironment()) on the DatabasePrimer will output 'dev' and then fail the check. Also it will not call the FakeYahooFinanceApiClient but the regular one. Seems that it is not at all obeying services_test.yaml. I did compare my code to your repo and all seems fine. I am using Symfony 5.4. Any ideas?
@@GaryClarkeTech Thanks for replying. Yes, is there. Actually I downloaded your full code and updated to Symfony 5.4 ( 5.2 would not resolve) and the same issue there: $kernel->getEnvironment() is still returning 'dev'
Thanks for this video Gary! I have a question. I get an error when i use setUp in StockTest.php: Method 'App\Tests\StockTest::setUp()' is not compatible with method 'Symfony\Bundle\FrameworkBundle\Test\KernelTestCase::setUp()' Do you know what causes this problem? Maybe it is because i use symfony 4? If so how can i fix this for symfony 4 because i need to use it for my usecase
@@GaryClarkeTech I made a typo using Orm instead ORM in databaseprimer file. But now i have another problem because when i run the test it says: Caused by Doctrine\DBAL\Driver\PDO\Exception: could not find driver And: Caused by PDOException: could not find driver
Thank you very much for this awesome tutorial, even the speech flow is perfect ! It is good to see the concrete process of TDD. Do you think that it is possible to extend the process from the user story to the set of tests that should be created ? For exemple which user story could have led to the tests functions ? Again thanks a lot !
Hi Gary, great course, thanks a lot! I have created services_test.yaml with fake implementation but functional test is still using Amazon Api instead of fake implementation. I'm using Symfony 5.3. In your video you are using Symfony 5.2. Are there any changes in naming convention for yaml with tesing config?
Hi Krzysztof...no, config/services_test.yaml is still a thing in S5.3. You'll need to retrace your steps. Is your fake implementing YahooFinanceApiClientInterface?
Have a question about the first unit test. Isn't this actually integrational test ? Because it interacts with the database ? We are not checking some isolated functionality but creating record and retrieving it.
i dont understand, i did everything ike you and i got this error when i tried to run test Doctrine\DBAL\Driver\PDO\Exception: SQLSTATE[HY000]: General error: 1 no such table: product
I can't remember why I used it in this vid without watching it again. But symfony composer is used mainly for some shortcuts. If I need to have the symfony server for some things e.g. symfony server env vars then I'll prefix the command with symfony
I can't really remember..it was recorded a while ago. But being able to demonstrate using the container for test replacements was part of the thinking.
Hi Gary, sick shit! but is the api still working? I'm not able to navigate to the page of the api and not able to fetch any data.. getting a 403 response
gr thijs
I've not checked recently but no one else has mentioned it. 403 means there's some kind of problem with your creds. You set up auth the same way as me?
@@GaryClarkeTech nope used my own, thinks it does't work anymore cuz i am able to use other api's
@@thijsdew1988 ok..thanks for letting me know. I'll check it out when I get the chance.
I got the same 403 forbidden, but i had to add a creditcard with a basic plan $0/month but only 250 requests.
@@MrSonicastra Thanks for solving this. I'll pin this thread 🤝
One of the best TDD videos i've seen.
Great content, mate!
Thanks a lot..I appreciate it!
As for a fresh graduate programmer this course helped me A LOT while solving the technical task required for job application. Thank you, learned so many new things while double watching this course
That's wonderful Rosita..I'm glad I was able to help and I hope you get the job!
Finally some Symfony videos that really worth to watch...great work man
Glad you liked it!
Thanks for the very good tutorial
In minute 15:41 command should be > `symfony console make:command app:refresh-stock-profile`
Thanks Ahmed 👍
Amazing demo and great TDD mentoring!
This is great content 👏👏👏
I'd love to see more 🤞
Thanks for your work :)
Thanks Léo...I appreciate it 👍 I release a new recording every week.
Thank you so much for this high quality content.
I learned so much from this video and appreciate how you explained all the details.
After I failed with Symfony 5.2 - I had a dependency version conflict with DAMA/doctrine ... - I was able to recode everything with Symfony 5.3 nicely.
Nice one Martin...good man 👊
Thx Gary, as always your turorials give a lot the usefull stuf and configurations. This one is great!!! ;)
Thanks a lot. I appreciate it!
Who the hell has disliked this video??))))) Good job lots of thanks!s)
Hmm I have a stupid question maybe :) Should tests belong in the main repo ? On the dev branch ? Or just keep them locally on my machine ? Because eventually what's on the dev branch will eventually be merged in the production and deployed.
No such thing as a stupid question. Yes, tests belong in the main repo...they are as important as the code itself.
Amazing, i appreciate your efforts to show us all this stuff in one video, thank you again
Welcome Soufiane...so nice of you
Wow ! I didn't think that in-memory DB can be used for unit tests , thank you !
It indeed makes sense, because these DB are temporary, and each test have its own DB... This will avoid me to use mock objects to use the EntityManager then 🙂!
Yes, although you can do the same with non in-memory. In memory is just faster for this this kinda thing
I've been using Symfony and Spring framework and if you learn one you learn the other one without much effort. Both are great frameworks.
Thanks for sharing!
@@GaryClarkeTech thanks for your content.
I'm traying to do it, but in the minute 13:17 get this error:
1) App\Tests\StockTest::a_stock_record_can_be_created_in_the_database
Doctrine\ORM\Mapping\MappingException: Class "App\Entity\Stock" is not a valid entity or mapped super class.
Some idea?
This will possibly help..
stackoverflow.com/questions/7820597/class-xxx-is-not-a-valid-entity-or-mapped-super-class-after-moving-the-class-i
amazing work Gary, thank you so much!
You bet!
This is very helpful. Simple and a good test strategy
Glad it was helpful!
In the price tests, you should test for assertIsNumeric because sometimes it sends back whole dollar amounts with no cents (and it does't display xx.00) when that happens, the test will fail.
Cheers Andrew..well spotted
Hey Gary, thanks for the video. I am using symfony v6.2 and so far followed everything. in 13:10 of the video I get this error: There was 1 error:
1) App\Tests\StockTest::a_stock_record_can_be_created_in_db
Error: Call to a member function persist() on null
C:\wamp64\www\phpunit\tests\StockTest.php:45 Any idea what might be the cause?
Yes..looks like you don't have an entity manager...you're getting null instead.
Dump out your entity manager using dd() and see what you get then work backwards to figure out where you went wrong with it.
Thanks for the video Gary, but i got an issue at 42min in the video. I want to test YahooFinanceApiClientTest in integration folder, and i got 'Undefined property: stdClass::$price' i think its due this line off code: $stockProfile = json_decode($response->getContent())->price; any idea's? Thx
Trying dumping out the content like so..
dd($response->getContent());
What do you see?
@@GaryClarkeTech I got this: "{"total":76,"offset":0,"results":[{"exchangeCode":"AMS"},{"exchangeCode":"ASE"},{"exchangeCode":"ASX"},{"exchangeCode":"ATH"},{"exchangeCode":"BER"},{"exchangeCode":"BRU"},{"exchangeCode":"BSE"},{"exchangeCode":"BTS"},{"exchangeCode
":"BUD"},{"exchangeCode":"BUE"},{"exchangeCode":"CAI"},{"exchangeCode":"CCS"},{"exchangeCode":"CNQ"},{"exchangeCode":"CPH"},{"exchangeCode":"CSE"},{"exchangeCode":"DOH"},{"exchangeCode":"DUS"},{"exchangeCode":"EBS"},{"exchangeCode":"
ENX"},{"exchangeCode":"FKA"},{"exchangeCode":"FRA"},{"exchangeCode":"GER"},{"exchangeCode":"HAM"},{"exchangeCode":"HAN"},{"exchangeCode":"HEL"},{"exchangeCode":"HKG"},{"exchangeCode":"ICE"},{"exchangeCode":"IOB"},{"exchangeCode":"ISE
"},{"exchangeCode":"IST"},{"exchangeCode":"JKT"},{"exchangeCode":"JNB"},{"exchangeCode":"JPX"},{"exchangeCode":"KLS"},{"exchangeCode":"KOE"},{"exchangeCode":"KSC"},{"exchangeCode":"LIS"},{"exchangeCode":"LIT"},{"exchangeCode":"LSE"},
{"exchangeCode":"MCE"},{"exchangeCode":"MCX"},{"exchangeCode":"MEX"},{"exchangeCode":"MIL"},{"exchangeCode":"MUN"},{"exchangeCode":"NAE"},{"exchangeCode":"NCM"},{"exchangeCode":"NEO"},{"exchangeCode":"NGM"},{"exchangeCode":"NMS"},{"e
xchangeCode":"NSI"},{"exchangeCode":"NYQ"},{"exchangeCode":"NZE"},{"exchangeCode":"OSL"},{"exchangeCode":"PAR"},{"exchangeCode":"PCX"},{"exchangeCode":"PNK"},{"exchangeCode":"PRA"},{"exchangeCode":"RIS"},{"exchangeCode":"SAO"},{"exch
angeCode":"SAP"},{"exchangeCode":"SAU"},{"exchangeCode":"SES"},{"exchangeCode":"SET"},{"exchangeCode":"SGO"},{"exchangeCode":"SHH"},{"exchangeCode":"SHZ"},{"exchangeCode":"STO"},{"exchangeCode":"STU"},{"exchangeCode":"TAI"},{"exchangeCode":"TAL"},{"exchangeCode":"TLO"},{"exchangeCode":"TLV"},{"exchangeCode":"TOR"},{"exchangeCode":"TWO"},{"exchangeCode":"VAN"},{"exchangeCode":"VIE"}],"responseStatus":null}"
WOW !! this is amazing !! Thank You Gary !!
Thank you..I appreciate it!
Awesome content Gary!! Will follow it and enjoy it this weekend!
Thanks Jorge...enjoy!
@@GaryClarkeTech never used sqlite before and was getting a DriverException from Doctrine when running the first test, just sharing in case someone encounters the same problem. Fixed it by installing sqlite and uncommenting the sqlite lines in /etc/php/php.ini
Thinking that maybe starting the tutorials by creating the docker containers in which to work would eliminate this kind of local dependency issues for viewers.
Cheers Jorge..good tip. Glad you fixed it!
I am using a newer version of Symfony. All my tests are fine, but when I run the command, I get a "syntax error" reported from JsonDecode.php. However, there is no other information about what is causing this. I have not debugged yet (I have the hardest time getting xdebug to work with cli apps, but I will get there). Curious if anyone else has come across this error or has any ideas?
Thanks Gary, very nicely done.
Very welcome Bikal, cheers
Excellent tutorial, but you have extracted the finance API to an interface which completely dependent on Yahoo API, the fetch method should not have any arguments bonded to a specific API, maybe the next API does not require the symbol and region.
Yes..there are a few things about it I would change tbh
Great tutorial! Thanks.
I am running into an issue though. Somehow it will not set that its running on the test environment. dd($kernel->getEnvironment()) on the DatabasePrimer will output 'dev' and then fail the check. Also it will not call the FakeYahooFinanceApiClient but the regular one. Seems that it is not at all obeying services_test.yaml.
I did compare my code to your repo and all seems fine. I am using Symfony 5.4.
Any ideas?
Check your phpunit.xml file
This is where APP_ENV gets set to test
@@GaryClarkeTech Thanks for replying.
Yes, is there.
Actually I downloaded your full code and updated to Symfony 5.4 ( 5.2 would not resolve) and the same issue there:
$kernel->getEnvironment() is still returning 'dev'
Thanks for this video Gary! I have a question. I get an error when i use setUp in StockTest.php: Method 'App\Tests\StockTest::setUp()' is not compatible with method 'Symfony\Bundle\FrameworkBundle\Test\KernelTestCase::setUp()'
Do you know what causes this problem? Maybe it is because i use symfony 4? If so how can i fix this for symfony 4 because i need to use it for my usecase
Hi Fardin..it shouldn't be related to Symfony 4
Can you paste both methods here and I'll look?
@@GaryClarkeTech I made a typo using Orm instead ORM in databaseprimer file. But now i have another problem because when i run the test it says: Caused by
Doctrine\DBAL\Driver\PDO\Exception: could not find driver
And:
Caused by
PDOException: could not find driver
@@puffkitty007 Try this:
stackoverflow.com/questions/2852748/pdoexception-could-not-find-driver
Thank you very much for this awesome tutorial, even the speech flow is perfect ! It is good to see the concrete process of TDD.
Do you think that it is possible to extend the process from the user story to the set of tests that should be created ?
For exemple which user story could have led to the tests functions ?
Again thanks a lot !
I'm working on a full testing course atm which will probably include that stuff. Keep an eye out for updates.
Hi Gary, great course, thanks a lot!
I have created services_test.yaml with fake implementation but functional test is still using Amazon Api instead of fake implementation. I'm using Symfony 5.3. In your video you are using Symfony 5.2. Are there any changes in naming convention for yaml with tesing config?
Hi Krzysztof...no, config/services_test.yaml is still a thing in S5.3.
You'll need to retrace your steps. Is your fake implementing YahooFinanceApiClientInterface?
@@GaryClarkeTech thanks for the answer. It started to work on my machine after adding adding response types. Maybe it was the case of cache?
@@krzysztofmichalski7325 I had the exact same issue. Running ./bin/console cache:clear --env=test fixed me right up.
Have a question about the first unit test. Isn't this actually integrational test ? Because it interacts with the database ? We are not checking some isolated functionality but creating record and retrieving it.
Yes..it combines different types of tests to get max coverage. A lot of the time, I'll use an in-memory db instead of mocking
@@GaryClarkeTech Thank you for thw answer!
Thank you! Gary
Thanks for watching!
Thank you for your premium content.
You're welcome 👍
Thank you. Very useful.
Glad to hear that!
i dont understand, i did everything ike you and i got this error when i tried to run test
Doctrine\DBAL\Driver\PDO\Exception: SQLSTATE[HY000]: General error: 1 no such table: product
nvm i forgot about -> DatabasePrimer::prime($kernel);
That is indeed a strange error to receive because the only table I create in the whole tutorial is called stock.
What have you named your entity?
Awesome! Thanks Gary! :)
Great stuff
Thank you. the only think that I do not understand is why you run `symfony composer` or `symfony PHP instead of just `composer` or `PHP`
I can't remember why I used it in this vid without watching it again. But symfony composer is used mainly for some shortcuts. If I need to have the symfony server for some things e.g. symfony server env vars then I'll prefix the command with symfony
@@GaryClarkeTech BTW i replied to your email yesterday, can you please check it?
@@VazgenManukyan Sorry but I haven't seen it / can't see it. It went to info@garyclarke.tech ?
Just the right length
49:03 why you just didn't use mock?
I can't really remember..it was recorded a while ago. But being able to demonstrate using the container for test replacements was part of the thinking.
Thank you
Love this, thanks
You're welcome, Jordy
Thanks a lot !
You're welcome!
Amazing :D If I could, I would have given it a 100 likes, but only one is possible: D
Thanks Pawel..I appreciate the one!
awesome :)
Thanks Shambhu..appreciated