I appreciate that your sponsored content is just that and the tutorial is still pure and not "To do this tutorial, simply buy this sponsored content!" So many channels have fallen into that trap and it ruins the tutorials.
I love your video. However, some times I get lost in what code you are talking about since you are only show/talking about one part at a time (which I love because it big and clear, I just not sure which script it belongs too). Could you maybe put the name of the Script in the corner for each time you are showing it? Keep up the great work and watching your videos is inspiring!
Thanks for making this! I had an artist request a way to take screenshots for item icons in Unity a few weeks ago and it was just sitting on the backlog. This worked perfectly and I adapted it to our needs.
I did the same for a long time, now i can start a project and mess around a bit with ideas, it can be fun and useful at the same time watching these kind of stuff, just to expand your knowledge and way of thinking, you'll have a starting point if you ever decided to play around with game dev.
I don't know where you put or create that InventoryItem public class. The tutorial is great and compact but the lack of information on where things go is frustrating XD
There's a lot of holes in this tutorial. All of the .current need to be explained. onInventoryChangedEvent and UIInventoryItemSlot aren't explained either
.current is explained in his other video about events, basically go to the top and make put in "public static InventorySystem current;", then go to the private void Awake() and put "current = this;", as for UIInventoryItemSlot i'd like to know myself i'm going crazy over here
Do you know where "ItemController" comes from!? at 7:40 I don't have itemController and it doesn't work if I do it with my script that has OnHandlePickupItem in it ;_;
Matt please do a series on the new input system, the way you explain concepts and things is so straight forward! would love to see a few videos on this topic
I have a problem. I am stuck at the Icon Generator [ 4:00 ]bc it just does not work. The tutorial does not show the whole piece of code and I'm a newb and don't know what to do. please help.
I like how you showcase the system itself. I understood the system itself and it is very good way to create efficient workflow for inventories. However the way you explain codes in sliced screenshot is confusing especially to newer programmers. I hope you can recreate more tutorial for beginners in mind because admittedly most people that watch tutorials are beginner in programming itself. And for advanced user you can make a disclaimer at the star or title itself.
Thanks for the info and the added extra bits too. Like the fact we can use unity to create, and import icons. I had created 40+ icons via copying my entire desktop screen and croping the icon out by hand.
The shown code is missing some important bits like the onInventoryChanged event handler and the InventorySystem singleton instance but overall helpful video.
@@gedjucius2418 It is not that hard even for a beginner. You should not dive this deep if you don't have basic knowledge. Join his community discord server and ask for help. They will help you in no time.
Great work, but I'm a bit lost. I've checked a few times the video and didn't saw when you've added the definition ''current'' in the InventorySystem script and second is there a playlist to show what you did in order before that video?
@@GameDevGuide Dude do you even know how "a tutorial" is work? Not everyone know what the fuck is a singleton, and this kind of scripts need to be completed so it can work.
Tbh this tutorial is really unclear. The creator uses a singleton, but never explains how it works on a visible example. The viewer has to guess what kind of library the creator is using. A lot of question without answert. Not recommended for beginners.
At what point did you make inventory system a singleton and what is .current? The closest I could find to that is a property in IEnumerator, so is it something you put into the InventorySystem offscreen? Or did you bring something into the class specifically for you to call that?
yea exactly, like it's a good video except for the fact that there are huge holes in context and he only hearts comments that are positive, these comments go un-replied to and it gets infuriating to a point
Maybe its a late answer, but in case anybody searchs for the same thing declare a "public static InventorySystem current;" variable inside the InventorySystem script and inside the "private void Awake" function instantiate the current variable (currently empty) using : "current = this;" if you do it like he did in the tutorial Hope its helpful for any dev wondering in the future
This is really well made and smooth as butter, well done! The icons look cool and a really clever way to capture them, I never thought of that. I've seen similar done in Blender before, but never before in Unity. Thanks for sharing I'm off to to watch more of your videos - great content!
change your InventorySystem script like this. public class InventorySystem : MonoBehaviour { public static InventorySystem current; private Dictionary m_itemDictionary; public List inventory; private void Awake() { current = this; inventory = new List(); m_itemDictionary = new Dictionary(); }
@@koopee8577 just replace some part of the InventorySystem class script added this on variable declarations "public static InventorySystem current;" added this on Awake method "current = this;"
Alot of holes in this tutorial. Maybe make this part of a series so people are going to know that this tutorial is using other parts from earlier tutorials? Something like " tutorial part x (Inventory system)"? Looks like a general tutorial at first but when you actually start to follow this later in the video you realize it's using alot of stuff from other videos. Learned some new stuff anyways so thanks about that but could have spent my time more productively if i would have known this beforehand!
so... basicaly... the postman broke into your house and will not leave until you rob the house yourself and give the items to the postman... 100IQ postman right there
How did you do the screenshotting for the items i'm using everything that you showed in the video but i just have a lot of errors Did you use another part of the UnityEngine that i haven't? just wondering because it would really save a lot of time
@Elliott Childs Yhea thats the easy solution, I was thinking in doing that, but where is the fun part of programming? xd (if I cant solve the errors im going to do that)
Hiya! I managed to make my way through the tutorial fairly easily, but I've just got one problem. "onInventoryChangedEvent" This doesn't work without other behind the scenes stuff that I don't know right now. Could you help?
Sorry, but the way you present the code is very confusing resulting in a bad tutorial. Some of it is shown as bits, some of it comes in the wrong order, some like the "itemContoller" we're never even shown. I would say this definitely for advanced users who can fill the gaps themselves which renders the tutorial useless in the first place.
I have an issue in my code and can't solve it myself. Thanks for helping in advance... Heres this problem... i wrote InventorySystem.current.Add(referenceItem); inside of the item object script, but then unity tells me inventorysystem does not contain a definition for current... how can i solve this?
To anyone getting "error CS0246: The type or namespace name 'Serializable' could not be found" you just need to add System. Infront first~ "[System.Serializable]"
I got lost at 4:00 because it only shows a snippet of code - I am new to unity so trying to figure this out was really difficult, is there a place where I can see the full IconGenerator code?
using System.Collections; using System.Collections.Generic; using UnityEditor; using UnityEngine; public class TakeScreenshot : MonoBehaviour { Camera cam; public string pathFolder;
@@aleks_gavs oh for real? I did not found that comment, thanks none the less, your comment is much more to the top I assume so this saves me time, which I'm glad, Have a Good Day.
Unity is a complex program. I understand as a YT person you want to keep your videos at about 10 minutes. But you went wayy to fast without explanation of how things actually work.
I can't seem to be able to see the Inventory list in the inspector, if I don't put the private set I can only see it as an element, but it doesn't display with all its properties for some reason
It was an awesome tutorial! Especially the screenshot system was amazing. Now to figure out how the letter is going to get to the postman when the postman has to deliver it ;)
I was having some dramas getting the inventorysystem to serialize, the public getter and private setter in the inventoryitem list definition within the inventorysystem, and then the same for the data and stacksize attributes in the inventoryitem were blocking the serialization... (this is actually seen at 8:03, as there are no attributes when the inventorysystem is added) no messages, nothing. this was on 2020.3.24f1. Modifying these lines to remove the getter/setter allowed the serialization as seen at 8:12. those playing along at home need simply change "public List inventory {get; private set;}" to "public List inventory;", rince and repeat for the same style of lines in the InventoryItem script.
I just wanted to circle back as I've learnt another way to solve the problem above; You can forcibly serialize using "[field: SerializeField]" and it achieves the same outcome as removing the getter/setter declaration.
@@HackEndLess Check that you have your InventoryItem class "[Serializable]", that you've used "[field: serializefield]" on each of the items that have the getters defined in line. In the InventorySystem class you will need to do the same field declaration for the "inventory" list defined within it... you cant serialise the dictionary so if you're expecting that to appear you're out of luck.
@@Seriphis2200 I did everything you and others said but still can't serialize inventory list nothing worked for me, I even upgraded Unity version to 2020.3.27f1 from 2020.3.20f1. Anyway thanks for the help. It's not a big deal because system works. So I give up on that.
Hey pretty random but any chance you could make a tutorial on placing Unity UI elements beneath each other. I am trying to make some buttons under scrolling text that chages size. I keep thinking I should be able to set the buttons to say layout below text, kind of like in android studio, but I see no such feature in unity. Thanks for any help!
With these scriptable objects, it looks to me like they are best used when you have an item that doesn't change its state at all, since it just references the asset. But if you want to create an inventory system like say, Minecraft, whereby using an item reduces its durability, can SOs allow for individual changes in these items?
Hello! I loved the tutorial. It has really helped our game. When generating icons using the universal render pipeline, I can't get the background transparent. I've tried a) different background types b) turning off post-processing c) setting a culling mask d) desperate other changes haha. Has anyone else had problems?
Amazing tutorial! My only issue was that the InventorySystem.current didnt work, there is no refference to something called "current" could anyone please help? Thanks
This part was very glossed over, so I'll explain. A singleton is a kind of static object, which can be accessed from any script. To do that, you'll have to instantiate an instance of the singleton. Googling what "current" means in unity will only bring you to the one regarding Events, which isn't accurate. For my singletons, I use the name instance. So, at the top of the InventorySystem script, you should write: private static InventorySystem _instance; public static InventorySystem Instance => _instance; Then, inside your awake function (create one if you don't have one!), write some code that makes sure there is ONLY ONE instance of the singleton: if (_instance != null) { Debug.Log("there's already an instance of this singleton!") Destroy(_instance); return; } _instance = this; Now, when implementing this code, replace "current" with Instance when it's outside of the InventorySystem script, and _instance when it's inside.
3:59 Dont we hate tutorials when full script not showed. it wont work without adding needed things. how i get button to click screen shot or that menu LOL
Great tutorial. Very small but I think you forget to add to the stack when new inventory is added but is not already within the dictionary (at 6.37). I also don't really understand why you separate out InventoryItemData and InventoryItem. I know people can be averse to putting behaviour on scriptable objects but it seems cleaner / simpler to me to consolidate all the data about the inventory item in one place.
Where did you declare the "current" variable in the InventorySystem class???? Edit: I figured out how to do it in my own way. Damn I love how you get a lot of information out in a short amount of time, but you didn't show all the code you were using so I had to actually use my lazy comp sci brain to fill in the gaps.
@@mashedpotatonl7966 I haven't implemented full thing yet but I just created an inventory system item in my interactable class and just did inventorySystem.inventory.add(referenceItem)
The EnforcePresetPostProcessor Script have 2 errors by me. AssetDatabase' does not contain a definition for 'RegisterCustomDependency' Assets\Editor\EnforcePresetPostProcessor.cs(68,24): error CS1061: 'AssetImportContext' does not contain a definition for 'DependsOnArtifact' and no accessible extension method 'DependsOnArtifact' accepting a first argument of type 'AssetImportContext' could be found (are you missing a using directive or an assembly reference?)
Okay WTF, You are not even showing the full script for the Icon Generator only the function. as a beginner this is very hard to follow. Do we need a private Camera camera; variable? what more variables do we need if any? Like how do I set the prefix and Path Folder
Please make a complete tutorial on shop system for abilities, weapons and characters please no one is talking about this I'm stuck i want a start menu shop system where you buy and select items you will use in match in another scene please 🥺
Hi, is it possible to get some help with getting the UI for inventory to work with my code? I was getting a bunch of errors and they were from missing gaps of code which I've fixed but for some reason the UI doesn't seem to be working still. I'm no longer getting errors but it doesn't add or remove the image icons when I pickup items
Make sure TakeScreenshot is public, then create this script to make taking screenshots easier: ``` using UnityEditor; using UnityEngine; [CustomEditor(typeof(TakeThumbnail))] public class TakeThumbnailEditor : Editor { public override void OnInspectorGUI() { // Draw the default inspector DrawDefaultInspector(); // Add a button to take a screenshot TakeThumbnail takeThumbnailScript = (TakeThumbnail)target; if (GUILayout.Button("Take Screenshot")) { string path = EditorUtility.SaveFilePanel("Save Screenshot", "", "Thumbnail.png", "png"); if (path.Length != 0) { takeThumbnailScript.TakeScreenshot(path); } } } } ```
There's a literally one-line screenshot method that captures a screenshot from the game's view (which in this case is the same output of your camera). Why all the hassle?
InventoryItemData contains prefab field and then each item prefab should contain ItemObject component with referenceItem pointing on corresponding inventory item ScriptableObject.. huh? What is the purpose of this circular dependency? Is it to make it easy to drop item (move it from inventory into the world)? But how about spawning item (e.g. to randomize initial stamp positions) or adding it into inventory (deserializing)?
I got an error for the ItemObject script at 7:50. It says 'Inventory System' does not contain a definition for 'current.' In theory, I understand what a singleton is, but I feel like this section was glossed over quickly. I'm inexperienced and thus missing something that should probably be really obvious.
A singleton is an object that can be accessed from any script. To do that, you'll have to instantiate an instance of the singleton. Write some code that makes sure there is ONLY ONE instance of the singleton. Googling what "current" means in unity will only bring you to the one regarding Events, which isn't accurate. for my singletons, I use the name instance. So, at the top of the InventorySystem script, you should write: private static InventorySystem _instance; public static InventorySystem Instance => _instance; Then, inside your awake function (create one if you don't have one!), write: if (_instance != null) { Debug.Log("there's already an instance of this singleton!") Destroy(_instance); return; } _instance = this; Now, when implementing this code, replace "current" with Instance when it's outside of the InventorySystem script, and _instance when it's inside.
@@nomatyx5789yeah no worries! You explained what singletons were and gave code on how to properly implement the system into the game. (Which worked perfectly)
@@kalashio awesome :) glad i could help! i went on some comment retrieval site and found my comment-- there's one thing i'd like to clear up. All static variables are able to be accessed by the whole program. Singletons are just a certain type of static variable. The difference between a singleton and a static variable is the "if(_instance != null){Destroy(_instance);} bit. That's essentially saying "there can only be one instance of this", which is important for things like an inventory where you only want one
Nope and that's by design! Most of the way I approach content here is just me teaching something to another, slightly less experienced, version of myself. 😂 And I fully expect most people watching to be at a similar point. This is because there are plenty of other incredibly talented creators here on TH-cam for beginners. 👌🏻 So I don't need to be competing in that space, nor do I want to. Thanks for watching though, hopefully you'll find the channel more useful later in your gamedev journey!
@@GameDevGuide Explaining this before the tutorial starts is important! Many people looking for this type of tutorial are beginners. I gave up after 7 minutes. 7:40 That part of the video is very confuse! I just wasted my time.
I appreciate that your sponsored content is just that and the tutorial is still pure and not "To do this tutorial, simply buy this sponsored content!" So many channels have fallen into that trap and it ruins the tutorials.
I love your video. However, some times I get lost in what code you are talking about since you are only show/talking about one part at a time (which I love because it big and clear, I just not sure which script it belongs too). Could you maybe put the name of the Script in the corner for each time you are showing it?
Keep up the great work and watching your videos is inspiring!
at the top of the scripts it says what the script is
@@lorilongwell5451 not always, really got confused with the Update function script that didn't have a name
Thanks for making this! I had an artist request a way to take screenshots for item icons in Unity a few weeks ago and it was just sitting on the backlog. This worked perfectly and I adapted it to our needs.
Me watching this for fun know full well that I'm never gonna use this: Hmm interesting... This will be useful... Probably.
I did the same for a long time, now i can start a project and mess around a bit with ideas, it can be fun and useful at the same time watching these kind of stuff, just to expand your knowledge and way of thinking, you'll have a starting point if you ever decided to play around with game dev.
the screenshot thing blew my mind ngl
I don't know where you put or create that InventoryItem public class.
The tutorial is great and compact but the lack of information on where things go is frustrating XD
@Eigulite I didn't (I have the same problem)
@@crazytm8942 it goes in the script InventorySystem in between void awake and void add.
@@archive5500 thank you!
There's a lot of holes in this tutorial. All of the .current need to be explained. onInventoryChangedEvent and UIInventoryItemSlot aren't explained either
.current is explained in his other video about events, basically go to the top and make put in "public static InventorySystem current;", then go to the private void Awake() and put "current = this;", as for UIInventoryItemSlot i'd like to know myself i'm going crazy over here
@@TactfulWaggle UIInventoryItemSlot is supposed to be the name of the slot script mentioned a few seconds earlier
Do you know where "ItemController" comes from!? at 7:40
I don't have itemController and it doesn't work if I do it with my script that has OnHandlePickupItem in it ;_;
@@TheCatMurgatroyd No Clue man, I never got around to putting this to work. Just went on and found another tutorial more in depth
@@brurrik Do you remember which one? I followed another one but was too stupid ;_;
Matt please do a series on the new input system, the way you explain concepts and things is so straight forward! would love to see a few videos on this topic
Love the simplicity of the UI! Thank you so much for showing us this!
You're getting sponsers now? Lil Matts growing up! Making us so proud :D nice work buddy!
That screenshot script looks extremely useful and easy to implement. I've been trying to find one that was usable for quite some time.
There's a one-line screenshot method in unity which captures the game view and saves it at the location you pass as a parameter
@@mohammadsadeghlavaie5560 lol did you not watch the video?
I love how compact your code is.
This beats watching 10 tutorials to make an inventory lmao
Really well done and quick
I have a problem. I am stuck at the Icon Generator [ 4:00 ]bc it just does not work. The tutorial does not show the whole piece of code and I'm a newb and don't know what to do. please help.
using System.Collections;
using System.Collections.Generic;
using UnityEditor;
using UnityEngine;
public class TakeScreenshot : MonoBehaviour
{
Camera cam;
public string pathFolder;
public List sceneObjects;
public List dataObjects;
private void Awake()
{
cam = GetComponent();
}
[ContextMenu("Screenshot")]
private void ProcessScreenshots()
{
StartCoroutine(Screenshot());
}
private IEnumerator Screenshot()
{
for (int i = 0; i < sceneObjects.Count; i++)
{
GameObject obj = sceneObjects[i];
InventoryItemData data = dataObjects[i];
obj.gameObject.SetActive(true);
yield return null;
TakeShot($"{Application.dataPath}/{pathFolder}/{data.id}_Icon.png");
yield return null;
obj.gameObject.SetActive(false);
Sprite s = AssetDatabase.LoadAssetAtPath($"Assets/{pathFolder}/{data.id}_Icon.png");
if(s!= null)
{
data.icon = s;
EditorUtility.SetDirty(data);
}
yield return null;
}
}
public void TakeShot(string fullPath)
{
if(cam == null)
{
cam = GetComponent();
}
RenderTexture rt = new RenderTexture(256, 256, 24);
cam.targetTexture = rt;
Texture2D screenShot = new Texture2D(256, 256, TextureFormat.RGBA32, false);
cam.Render();
RenderTexture.active = rt;
screenShot.ReadPixels(new Rect(0, 0, 256, 256 ), 0, 0);
cam.targetTexture = null;
RenderTexture.active = null;
if (Application.isEditor)
{
DestroyImmediate(rt);
}
else
{
Destroy(rt);
}
byte[] bytes = screenShot.EncodeToPNG();
System.IO.File.WriteAllBytes(fullPath, bytes);
#if UNITY_EDITOR
AssetDatabase.Refresh();
#endif
}
}
@@christofstanits hi, i dont know why is keep saving as one sprite any solutions? same code *edit you know what, I'm dumb, I forgot to assign the id
@@christofstanits Thank you so much! This is an absolute life-saver!
I like how you showcase the system itself. I understood the system itself and it is very good way to create efficient workflow for inventories. However the way you explain codes in sliced screenshot is confusing especially to newer programmers. I hope you can recreate more tutorial for beginners in mind because admittedly most people that watch tutorials are beginner in programming itself. And for advanced user you can make a disclaimer at the star or title itself.
Thanks for the info and the added extra bits too. Like the fact we can use unity to create, and import icons. I had created 40+ icons via copying my entire desktop screen and croping the icon out by hand.
This man did a Core add while doing a unity tutorial
Ironic
@@martimking1craft *Iconic
The shown code is missing some important bits like the onInventoryChanged event handler and the InventorySystem singleton instance but overall helpful video.
did you solve how to get the on inventorychanged event i cant seem to think of how to do it?
@@gedjucius2418 solved yet ??
@@xxragingkillerx8357 just subdcribe to an event that is called every time you change the inventory
this. i mostly needed to see how to make a menu and it just gets zero attention, annoying.
onInventoryChangedEvent was a little tricky for a beginner but I managed to get it working :D
Can you please explain how you did it? Thanks in advance :)
@@lucidjuice101 I followed his other tutorial "how to build an event system"
@@RoStepMusic Thanks for the info!
@@RoStepMusic i tried to follow that video but still seem to not know to do it
@@gedjucius2418 It is not that hard even for a beginner. You should not dive this deep if you don't have basic knowledge. Join his community discord server and ask for help. They will help you in no time.
yo, this is such a good video. straight to the point, no bullshit or 50minute expl of each concept
Great work, but I'm a bit lost. I've checked a few times the video and didn't saw when you've added the definition ''current'' in the InventorySystem script and second is there a playlist to show what you did in order before that video?
As mentioned in the video, I turned it into a singleton. Lookup singletons in C# / Unity for more info.
@@GameDevGuide Yeah my bad on that part. What about the playlist?
@@GameDevGuide where did you mention it?
@@GameDevGuide still lost lmao
@@GameDevGuide Dude do you even know how "a tutorial" is work? Not everyone know what the fuck is a singleton, and this kind of scripts need to be completed so it can work.
Tbh this tutorial is really unclear. The creator uses a singleton, but never explains how it works on a visible example. The viewer has to guess what kind of library the creator is using. A lot of question without answert.
Not recommended for beginners.
same. some really good ideas, but some basics glossed over.
agreed. I ended up going to another tutorial that does things step by step explaining each step instead of: here code good luck.
At what point did you make inventory system a singleton and what is .current? The closest I could find to that is a property in IEnumerator, so is it something you put into the InventorySystem offscreen? Or did you bring something into the class specifically for you to call that?
yeah, there are some hole in the tut.
yea exactly, like it's a good video except for the fact that there are huge holes in context and he only hearts comments that are positive, these comments go un-replied to and it gets infuriating to a point
.current is like
public static InventorySystem current;
Maybe its a late answer, but in case anybody searchs for the same thing
declare a "public static InventorySystem current;" variable inside the InventorySystem script
and inside the "private void Awake" function instantiate the current variable (currently empty) using : "current = this;" if you do it like he did in the tutorial
Hope its helpful for any dev wondering in the future
@@DaxVIII Veeery new to unity and yes, yes it was helpful. Searched for this for half an hour before coming to the comments here. Thank you
does anyone know what the "itemController" script is!? he shows it at 7:40
Thanks for the tutorial. I never would have thought of that screenshot method!
This is really well made and smooth as butter, well done! The icons look cool and a really clever way to capture them, I never thought of that. I've seen similar done in Blender before, but never before in Unity. Thanks for sharing I'm off to to watch more of your videos - great content!
Releasing this just after I struggled making an inventory system... thanks anyway, really useful in improving my own system!
Assets\Scripts\itemobject.cs(11,25): error CS0117: 'InventorySystem' does not contain a definition for 'current' ihave this eror
change your InventorySystem script like this.
public class InventorySystem : MonoBehaviour
{
public static InventorySystem current;
private Dictionary m_itemDictionary;
public List inventory;
private void Awake()
{
current = this;
inventory = new List();
m_itemDictionary = new Dictionary();
}
@@BANANADOMAU which part of the script do I replace this part with
@@koopee8577 just replace some part of the InventorySystem class script
added this on variable declarations "public static InventorySystem current;"
added this on Awake method "current = this;"
@@BANANADOMAU Thank you so much! I've been looking for this SINGLE piece of code forever and couldn't figure it out myself.
@@BANANADOMAU thank you so much! How'd you figure that out?
Would be really appreciated if you could tell us what UIInventoryItemSlot is or what it does or how it works, i'm completely stuck over here
Thank you Matt for making these videos for us, I have learned a lot from you. Keep making them
I feel like this video only helps people as smart as you...
He is leaving things out intentionally so that you can go watch his other videos about the parts left out.
Awesome content!
A production-ready level of inventory
Am I the only one stuck at the screenshot part I've copy the whole code but it doesnt work for me ?
how is camera not deprecated, why targettexture doesnt work ? help pls
Alot of holes in this tutorial. Maybe make this part of a series so people are going to know that this tutorial is using other parts from earlier tutorials? Something like " tutorial part x (Inventory system)"? Looks like a general tutorial at first but when you actually start to follow this later in the video you realize it's using alot of stuff from other videos. Learned some new stuff anyways so thanks about that but could have spent my time more productively if i would have known this beforehand!
Where is the onInventoryChangedEvent and where is the UIInventoryItemSlot? 9:13
I think UIInventoryItemSlot is a script where
```
[SerializeField]
private Image m_icon;
[SerializeField]
private TextMeshProUGUI m_label;
[SerializeField]
private GameObject m_stackObject;
[SerializeField]
private TextMeshProUGUI m_stackLabel;
public void Set(InventoryItem item)
{
m_icon.sprite = item.data.icon;
m_label.text = item.data.displayName;
if (item.stackSize
Great video! I loved how you generated the icons, that was pretty smart :)
i dont see why people cant put the script in description
Yeah or add a pastebin link with the code...
so... basicaly... the postman broke into your house and will not leave until you rob the house yourself and give the items to the postman... 100IQ postman right there
How did you do the screenshotting for the items
i'm using everything that you showed in the video but i just have a lot of errors
Did you use another part of the UnityEngine that i haven't?
just wondering because it would really save a lot of time
@Elliott Childs Yhea thats the easy solution, I was thinking in doing that, but where is the fun part of programming? xd (if I cant solve the errors im going to do that)
I realized your tactics are beyond my knowledge.
Half of the tutorial isn't even showing how to do an inventory system. The video is full of holes and skipped parts
First. Where's my Patreon fam at?
Just finished my inventory system for my game, but this will help me out a lot in improving it!
Excellent video, super flexible and offers a great starting point for any inventory system.
Hiya! I managed to make my way through the tutorial fairly easily, but I've just got one problem.
"onInventoryChangedEvent"
This doesn't work without other behind the scenes stuff that I don't know right now. Could you help?
Check out the event system video here on the channel!
Sorry, but the way you present the code is very confusing resulting in a bad tutorial. Some of it is shown as bits, some of it comes in the wrong order, some like the "itemContoller" we're never even shown. I would say this definitely for advanced users who can fill the gaps themselves which renders the tutorial useless in the first place.
This is just what I needed! How did you know? Thank you so much
I have an issue in my code and can't solve it myself. Thanks for helping in advance...
Heres this problem... i wrote InventorySystem.current.Add(referenceItem); inside of the item object script, but then unity tells me inventorysystem does not contain a definition for current... how can i solve this?
Ah sad.... I commented the exact same question yet I see you asked this 5 months ago with no response
To anyone getting "error CS0246: The type or namespace name 'Serializable' could not be found" you just need to add System. Infront first~ "[System.Serializable]"
Its Very Extreme Level Inventory System Very Hard.But Very Helpfull thanks
The timing of this video is impeccable! Love your videos, thank you!
I’m working on an inventory system and boom, this tutorial pops up.
Coincidence? I think not ;)
Posted 1 day ago! Great to see
I got lost at 4:00 because it only shows a snippet of code - I am new to unity so trying to figure this out was really difficult, is there a place where I can see the full IconGenerator code?
Same I wish he would show the whole thing
using System.Collections;
using System.Collections.Generic;
using UnityEditor;
using UnityEngine;
public class TakeScreenshot : MonoBehaviour
{
Camera cam;
public string pathFolder;
public List sceneObjects;
public List dataObjects;
private void Awake()
{
cam = GetComponent();
}
[ContextMenu("Screenshot")]
private void ProcessScreenshots()
{
StartCoroutine(Screenshot());
}
private IEnumerator Screenshot()
{
for (int i = 0; i < sceneObjects.Count; i++)
{
GameObject obj = sceneObjects[i];
InventoryItemData data = dataObjects[i];
obj.gameObject.SetActive(true);
yield return null;
TakeShot($"{Application.dataPath}/{pathFolder}/{data.id}_Icon.png");
yield return null;
obj.gameObject.SetActive(false);
Sprite s = AssetDatabase.LoadAssetAtPath($"Assets/{pathFolder}/{data.id}_Icon.png");
if(s!= null)
{
data.icon = s;
EditorUtility.SetDirty(data);
}
yield return null;
}
}
public void TakeShot(string fullPath)
{
if(cam == null)
{
cam = GetComponent();
}
RenderTexture rt = new RenderTexture(256, 256, 24);
cam.targetTexture = rt;
Texture2D screenShot = new Texture2D(256, 256, TextureFormat.RGBA32, false);
cam.Render();
RenderTexture.active = rt;
screenShot.ReadPixels(new Rect(0, 0, 256, 256 ), 0, 0);
cam.targetTexture = null;
RenderTexture.active = null;
if (Application.isEditor)
{
DestroyImmediate(rt);
}
else
{
Destroy(rt);
}
byte[] bytes = screenShot.EncodeToPNG();
System.IO.File.WriteAllBytes(fullPath, bytes);
#if UNITY_EDITOR
AssetDatabase.Refresh();
#endif
}
}
@@aleks_gavs Thank you sooo much!
@@TheJakeblake I copied it from another comment)
@@aleks_gavs oh for real? I did not found that comment, thanks none the less, your comment is much more to the top I assume so this saves me time, which I'm glad, Have a Good Day.
Unity is a complex program. I understand as a YT person you want to keep your videos at about 10 minutes. But you went wayy to fast without explanation of how things actually work.
I love you made the video for us but the jumping around is confusing me, i don't know where what code belongs?
I can't seem to be able to see the Inventory list in the inspector, if I don't put the private set I can only see it as an element, but it doesn't display with all its properties for some reason
remove the {get set} from both the InventorySystem and the InventoryItem scripts :)
@@TVBUDDHAS Thank you- this helped! Why is that?
It was an awesome tutorial! Especially the screenshot system was amazing. Now to figure out how the letter is going to get to the postman when the postman has to deliver it ;)
did you figure out how to use the items once they're in your inventory?
In this example, I think you set a reference to the corresponding Scriptable Object in each Item prefab, correct?
Bro if you have to do a tutorial at least show full stuff not incomplete scripts for beginners like someone in this comments
I was having some dramas getting the inventorysystem to serialize, the public getter and private setter in the inventoryitem list definition within the inventorysystem, and then the same for the data and stacksize attributes in the inventoryitem were blocking the serialization... (this is actually seen at 8:03, as there are no attributes when the inventorysystem is added) no messages, nothing. this was on 2020.3.24f1.
Modifying these lines to remove the getter/setter allowed the serialization as seen at 8:12.
those playing along at home need simply change "public List inventory {get; private set;}" to "public List inventory;", rince and repeat for the same style of lines in the InventoryItem script.
I just wanted to circle back as I've learnt another way to solve the problem above; You can forcibly serialize using "[field: SerializeField]" and it achieves the same outcome as removing the getter/setter declaration.
@@Seriphis2200 I did both ways but still can't serialize that list
@@HackEndLess Check that you have your InventoryItem class "[Serializable]", that you've used "[field: serializefield]" on each of the items that have the getters defined in line. In the InventorySystem class you will need to do the same field declaration for the "inventory" list defined within it... you cant serialise the dictionary so if you're expecting that to appear you're out of luck.
@@Seriphis2200 I did everything you and others said but still can't serialize inventory list nothing worked for me, I even upgraded Unity version to 2020.3.27f1 from 2020.3.20f1. Anyway thanks for the help. It's not a big deal because system works. So I give up on that.
@@HackEndLess Thats a bummer, if its working then great but thats super frustrating. Best of luck with your project.
Hey pretty random but any chance you could make a tutorial on placing Unity UI elements beneath each other. I am trying to make some buttons under scrolling text that chages size.
I keep thinking I should be able to set the buttons to say layout below text, kind of like in android studio, but I see no such feature in unity.
Thanks for any help!
This video is not your best work. Feels very rushed and is honestly a headache to follow.
Edit: Perhaps include links to the code?
Where is he getting "current" from in the line "InventorySystem.current.Add(referenceItem);?
Also thanks to core for supporting your content
At 8:13 how did you manage to view the inventory in the inspector?
I didnt think Unity would show public list's in the inspector.
two ways, one way just set the list to serializable, second way just use debug mode
@@huoguoji1354 I did set the list to serializable, but that did not make it show up.
@@raniem4368 maybe use the debug mode method， that usually works
@@raniem4368 the debug work for me
@@huoguoji1354 awesome. Thanks
With these scriptable objects, it looks to me like they are best used when you have an item that doesn't change its state at all, since it just references the asset. But if you want to create an inventory system like say, Minecraft, whereby using an item reduces its durability, can SOs allow for individual changes in these items?
I enjoyed watching this a lot! Well done
do you have to use the screenshot script to make the icons?
No
This came exactly when i needed it
Thanks! :D
Not very helpful leaving all the holes in everything.
Hello! I loved the tutorial. It has really helped our game.
When generating icons using the universal render pipeline, I can't get the background transparent. I've tried a) different background types b) turning off post-processing c) setting a culling mask d) desperate other changes haha.
Has anyone else had problems?
for me i changed the background type to uninitialized and it worked, make sure youre encoding to png not jpg
Ur amazing omg this is the right place to find a genius developer with useful and pro content, but can we get a haptic feedback vid?
Can u do video about quest system with scriptable object?
Guid on Unity and sponsored by Core made on Unreal 👀
Amazing tutorial! My only issue was that the InventorySystem.current didnt work, there is no refference to something called "current" could anyone please help? Thanks
You need to create a singleton with the inventory script
hey yea i have a same error like @Niksstuff so' how can i do it? @AleyisErussard
@@_Business.Guide_ I've said it, you need to create a singleton
This part was very glossed over, so I'll explain. A singleton is a kind of static object, which can be accessed from any script. To do that, you'll have to instantiate an instance of the singleton.
Googling what "current" means in unity will only bring you to the one regarding Events, which isn't accurate. For my singletons, I use the name instance. So, at the top of the InventorySystem script, you should write:
private static InventorySystem _instance;
public static InventorySystem Instance => _instance;
Then, inside your awake function (create one if you don't have one!), write some code that makes sure there is ONLY ONE instance of the singleton:
if (_instance != null) {
Debug.Log("there's already an instance of this singleton!")
Destroy(_instance);
return;
}
_instance = this;
Now, when implementing this code, replace "current" with Instance when it's outside of the InventorySystem script, and _instance when it's inside.
3:59 Dont we hate tutorials when full script not showed. it wont work without adding needed things.
how i get button to click screen shot or that menu LOL
Great tutorial. Very small but I think you forget to add to the stack when new inventory is added but is not already within the dictionary (at 6.37). I also don't really understand why you separate out InventoryItemData and InventoryItem. I know people can be averse to putting behaviour on scriptable objects but it seems cleaner / simpler to me to consolidate all the data about the inventory item in one place.
Where did you declare the "current" variable in the InventorySystem class???? Edit: I figured out how to do it in my own way. Damn I love how you get a lot of information out in a short amount of time, but you didn't show all the code you were using so I had to actually use my lazy comp sci brain to fill in the gaps.
How did you fix it? Stuck there now :P
@@mashedpotatonl7966 I haven't implemented full thing yet but I just created an inventory system item in my interactable class and just did inventorySystem.inventory.add(referenceItem)
The EnforcePresetPostProcessor Script have 2 errors by me.
AssetDatabase' does not contain a definition for 'RegisterCustomDependency'
Assets\Editor\EnforcePresetPostProcessor.cs(68,24): error CS1061: 'AssetImportContext' does not contain a definition for 'DependsOnArtifact' and no accessible extension method 'DependsOnArtifact' accepting a first argument of type 'AssetImportContext' could be found (are you missing a using directive or an assembly reference?)
Okay WTF, You are not even showing the full script for the Icon Generator only the function. as a beginner this is very hard to follow. Do we need a private Camera camera; variable? what more variables do we need if any? Like how do I set the prefix and Path Folder
Please make a complete tutorial on shop system for abilities, weapons and characters please no one is talking about this I'm stuck i want a start menu shop system where you buy and select items you will use in match in another scene please 🥺
The screenshot script didn't work for me :(
Hi, is it possible to get some help with getting the UI for inventory to work with my code? I was getting a bunch of errors and they were from missing gaps of code which I've fixed but for some reason the UI doesn't seem to be working still. I'm no longer getting errors but it doesn't add or remove the image icons when I pickup items
Im in the same place. Any info on this would be great.
8:23
Game UI Database
Also, thanks for the tutorial!
how do you get the on inventorychanged event i cant seem to think of how to do it?
thank you for this amazing tutorial
Everytime I try and use the handle function in the itemObject it adds an empty slot to the list
And I need to use one of this itens to trigger an open door or a character?
Could you make a video about saving the inventory? I really enjoyed this video but found that this is the only thing missing.
I actually have a save system video on the channel. You should be able to extrapolate that to save your inventory!
Make sure TakeScreenshot is public, then create this script to make taking screenshots easier:
```
using UnityEditor;
using UnityEngine;
[CustomEditor(typeof(TakeThumbnail))]
public class TakeThumbnailEditor : Editor
{
public override void OnInspectorGUI()
{
// Draw the default inspector
DrawDefaultInspector();
// Add a button to take a screenshot
TakeThumbnail takeThumbnailScript = (TakeThumbnail)target;
if (GUILayout.Button("Take Screenshot"))
{
string path = EditorUtility.SaveFilePanel("Save Screenshot", "", "Thumbnail.png", "png");
if (path.Length != 0)
{
takeThumbnailScript.TakeScreenshot(path);
}
}
}
}
```
There's a literally one-line screenshot method that captures a screenshot from the game's view (which in this case is the same output of your camera). Why all the hassle?
Because this method supports saving from any camera, regardless of what's in the game view.
@@GameDevGuide that's cool 👌
How to create Screenshot button like in video at 4:14 ?
I can't create it either. Can anyone help?
[ContextMenu("Screenshot")] in video at 4:46
InventoryItemData contains prefab field and then each item prefab should contain ItemObject component with referenceItem pointing on corresponding inventory item ScriptableObject.. huh? What is the purpose of this circular dependency? Is it to make it easy to drop item (move it from inventory into the world)? But how about spawning item (e.g. to randomize initial stamp positions) or adding it into inventory (deserializing)?
can you do a video about how to design and build an xml importer for items and missions?
I got an error for the ItemObject script at 7:50. It says 'Inventory System' does not contain a definition for 'current.' In theory, I understand what a singleton is, but I feel like this section was glossed over quickly. I'm inexperienced and thus missing something that should probably be really obvious.
A singleton is an object that can be accessed from any script. To do that, you'll have to instantiate an instance of the singleton. Write some code that makes sure there is ONLY ONE instance of the singleton.
Googling what "current" means in unity will only bring you to the one regarding Events, which isn't accurate. for my singletons, I use the name instance. So, at the top of the InventorySystem script, you should write:
private static InventorySystem _instance;
public static InventorySystem Instance => _instance;
Then, inside your awake function (create one if you don't have one!), write:
if (_instance != null)
{
Debug.Log("there's already an instance of this singleton!")
Destroy(_instance);
return;
}
_instance = this;
Now, when implementing this code, replace "current" with Instance when it's outside of the InventorySystem script, and _instance when it's inside.
@@nomatyx5789 Thank you so much, actually amazing
@@kalashio Sorry, could you remind me what my comment said? It seems to not be showing up for me
@@nomatyx5789yeah no worries! You explained what singletons were and gave code on how to properly implement the system into the game. (Which worked perfectly)
@@kalashio awesome :) glad i could help!
i went on some comment retrieval site and found my comment-- there's one thing i'd like to clear up. All static variables are able to be accessed by the whole program. Singletons are just a certain type of static variable.
The difference between a singleton and a static variable is the "if(_instance != null){Destroy(_instance);} bit. That's essentially saying "there can only be one instance of this", which is important for things like an inventory where you only want one
can you tell me your rig specs?
In InventorySystem, the [Serializable] line is giving me errors and nothing I change fixes it.
Try adding "using System;" to the top.
Great tutorial!
This is not beginnner friendly.
Nope and that's by design!
Most of the way I approach content here is just me teaching something to another, slightly less experienced, version of myself. 😂 And I fully expect most people watching to be at a similar point.
This is because there are plenty of other incredibly talented creators here on TH-cam for beginners. 👌🏻 So I don't need to be competing in that space, nor do I want to.
Thanks for watching though, hopefully you'll find the channel more useful later in your gamedev journey!
@@GameDevGuide Explaining this before the tutorial starts is important! Many people looking for this type of tutorial are beginners. I gave up after 7 minutes. 7:40 That part of the video is very confuse! I just wasted my time.
Thanks for the tutorial. It's quite easy to understand once you know where and what