CODE QUALITY REVIEW | PEOPLE GET REJECTED HERE

แชร์
ฝัง
  • เผยแพร่เมื่อ 20 ก.ค. 2024
  • Check our Website:
    In case you are thinking to buy courses, please check below:
    Link to get 20% additional Discount at Coding Ninjas: bit.ly/3wE5aHx
    Code "takeuforward" for 15% off at GFG: practice.geeksforgeeks.org/co...
    Code "takeuforward" for 20% off on sys-design: get.interviewready.io?_aff=takeuforward
    Crypto, I use the Wazirx app: wazirx.com/invite/xexnpc4u
    Take 750 rs free Amazon Stock from me: indmoney.onelink.me/RmHC/idje...
    Earn 100 rs by making a Grow Account for investing: app.groww.in/v3cO/8hu879t0
    Linkedin/Instagram/Telegram: linktr.ee/takeUforward
    ---------------------------------------------------------------------------------------------------------------------------------------------------- Check Relevel: relvl.co/xeby
    Check SDE SHEET/Telegram/Linkedin and others: linktr.ee/takeUforward
    Correction in Video: The reason for TLE might be the reason that .size() returns size_t which is unsigned, so if somehow .size()-1 was being calculated or anything that might turn the value to a negative number it would go to the maximum possible value of size_t which is huge. That's why many times we see something like if(i less than (int)g.size())
    Correction Credits: Aviral Rana

ความคิดเห็น • 109

  • @striver_79
    @striver_79  2 ปีที่แล้ว +90

    Please do like, share and subscribe ^ _ ^

    • @ashwinnema06
      @ashwinnema06 2 ปีที่แล้ว +2

      Please make the second video.This one was very informative

    • @saransinha4652
      @saransinha4652 2 ปีที่แล้ว

      Bhaiya ji @takeyouforword has lot of playlists but you have taught some topics like graph and recursion on @code beyond channel also .... so which one to follow 😬😬 please reply 🙏

    • @parth2439
      @parth2439 2 ปีที่แล้ว

      Already Done

    • @himanshushekher8994
      @himanshushekher8994 2 ปีที่แล้ว

      Make second video ,not much content is there on TH-cam on this topic

    • @mcraven281
      @mcraven281 2 ปีที่แล้ว +1

      We do need second part and would also love tutorial on SOLID principles

  • @piyushchaudhari397
    @piyushchaudhari397 2 ปีที่แล้ว +6

    1. Using auto keyword is best practice?
    For example: Function returning pair so to refer returned value using auto is recommendable?
    2. Can we use lambda functions (cpp) in interview? Or simple functions?

  • @arunachalamm3399
    @arunachalamm3399 2 ปีที่แล้ว +29

    bro do keep episode 2 of code quality as it helps students in identifying the mistakes they make and these things are not taught in colleges.. so will be useful bhaiya just like ur SDE sheet :))

  • @ishankbansal9239
    @ishankbansal9239 2 ปีที่แล้ว +27

    Bhaiya according to the c++ documentation (cplusplus reference) size() function takes constant time
    10:33

    • @shahnwazhusain9967
      @shahnwazhusain9967 2 ปีที่แล้ว +2

      Not only in c++. In every programming language size is declared as an attribute inside data structure implementation. Size gets updated using push or pop operations. Thats why accessing size is always O(1).

    • @shahnwazhusain9967
      @shahnwazhusain9967 2 ปีที่แล้ว

      besides that, great work by striver as always.

  • @noobbot7392
    @noobbot7392 2 ปีที่แล้ว +4

    should i always make each and every variable verbose, for eg, in for loop, writing iterator/index instead of i. Also should I write '{' on the same line of block creation or on next line. These are some basic queries I always have whenever I try to write clean code. Can anybody help me here.

  • @sachinsharma1279
    @sachinsharma1279 2 ปีที่แล้ว +19

    People reject final year students on the basis of code quality, code modularity, CS Basics but will never select a student who is not very good ds algo and just average in ds algo but write excellent clean code modular code know CS basics like os dbms and cn in very deep. That is complete bias

  • @darkelixir2517
    @darkelixir2517 ปีที่แล้ว +7

    Yes part II please.
    Often we forget basics while solving higher level problems, thanks to you for reminding these.

  • @thekid3563
    @thekid3563 2 ปีที่แล้ว +60

    ur way of saying extremely welllll is very funny.....

  • @himangshubiswas542
    @himangshubiswas542 ปีที่แล้ว +2

    The principal is " Single responsibility principle" , which states that one class Or one function should have only one job to do. By doing this we can Modularise our code

  • @dilipsunar99
    @dilipsunar99 2 ปีที่แล้ว +8

    This is definitely going to help us code in a better way (quality wise). Thank you for the video.

  • @snigdh
    @snigdh 2 ปีที่แล้ว +6

    Nice bhai, naam sahi pronounce kar liya 🙂 and thanks for reviewing my code 😁

  • @TechUprise-by-Jyoti
    @TechUprise-by-Jyoti 2 ปีที่แล้ว +12

    Thank you so much bhaiya for always giving amazing quality content 🔥🔥
    No matter what anyone says about you and do controversy, we will always support you because you are here because of your own hardwork and dedication 😇💯

  • @kumaraishwary7900
    @kumaraishwary7900 2 ปีที่แล้ว +1

    Using operators in variable, won't it increases space complexity as it taking extra space in mem.

  • @vaishnavishrivastava3994
    @vaishnavishrivastava3994 ปีที่แล้ว +3

    Won't direc arrays be created again and again everytime the function is called? I feel it was a better practice to leave it outside the function. 12:00 timestamp

    • @sypher4735
      @sypher4735 ปีที่แล้ว

      Yeah, but i don't feel like those 8 integers gonna affect much, obviously it's constant

  • @MuhammadYousaf-mz2gd
    @MuhammadYousaf-mz2gd 2 หลายเดือนก่อน

    There are 4 main Take away from Video
    1)Devide Code into Function(if needed)
    2)Variable name should be meaning full.
    3)if there are a lot of condition in single if block then make function of it.

  • @akashjaiswal6478
    @akashjaiswal6478 2 ปีที่แล้ว

    @Striver brother, In my college the interviews for placement session 2021-22 will starting from 1st December so, it's a request to upload the second part as soon as possible, thanks a lot, keep posting.....

  • @mddilshadalam8561
    @mddilshadalam8561 2 ปีที่แล้ว +5

    Hey striver
    I m in 2nd year bsc computer science student from west bengal.
    I had learn DSA and programming language(c++) and doing lot's of practice to do DSA / leetcode questions.
    I m learning frontend Web development write now I m on react (learning stage).
    I m not BTech student so will I able to get internship or product based company jobs ?

    • @Ishowmeat8
      @Ishowmeat8 2 ปีที่แล้ว +2

      If your resume is better than the other 999 people applying for the same position

  • @vishalshete5820
    @vishalshete5820 2 ปีที่แล้ว +3

    What a quality teaching man no one teach this things, and so engaging and interesting. awesome

  • @GeniuslyTensai
    @GeniuslyTensai 2 ปีที่แล้ว +3

    Bhaiya please make a another video showing how to give an interview....how to explain as well as solve the questions in the interview.

  • @Kuriocity
    @Kuriocity 2 ปีที่แล้ว +1

    @6:20 Abstraction

  • @aayushgoel4192
    @aayushgoel4192 2 ปีที่แล้ว +2

    Sir please do a second episode on code quality with more emphasis on classes and oops concept.Great respect cant give anything except thanks 🙏

  • @sakshamsrivastava6280
    @sakshamsrivastava6280 2 ปีที่แล้ว +3

    Such an amazing tips. thankyou man! Would love to see more videos on this topics

  • @JamesHalpert8555
    @JamesHalpert8555 2 ปีที่แล้ว

    Y condition checking in private fn. ? Didn't get that part.....

  • @sohel_sheikh
    @sohel_sheikh 2 ปีที่แล้ว +2

    Striver, please tell me if I use only functions instead of classes (or OOPS concepts). What do you think about the code quality in this case?

  • @aakashgoswami2356
    @aakashgoswami2356 2 ปีที่แล้ว +6

    Bhai share your interview experience of google and facebook.

  • @GeniuslyTensai
    @GeniuslyTensai 2 ปีที่แล้ว +1

    Thank you so much! This video is a great learning bhaiyaa ❤️ this is a video no one talks about

  • @ng3w462
    @ng3w462 2 ปีที่แล้ว +1

    please bring a part 2...these information was really insightful!

  • @lucario4399
    @lucario4399 2 ปีที่แล้ว +1

    start at @2:31, before that he had explained why this video is important in interview perspective, by refrencing to google interview he had cleared.

  • @ramsai6141
    @ramsai6141 2 ปีที่แล้ว

    Heyy bro....which editor is that (after relevel promotion).....?

  • @sober_junkie5709
    @sober_junkie5709 2 ปีที่แล้ว

    i didnt get the part where he said use class of struct instead of pair of pairs

  • @mayursb2259
    @mayursb2259 2 ปีที่แล้ว +1

    Listen to kunal kushwaha's podcast with his own google recruiter ... What she said should definitely put your ego down ..!! I came specially to invite you to listen privately as you do ..!!

  • @shiladityabose7770
    @shiladityabose7770 2 ปีที่แล้ว

    Raj bhaiya using too much functions in a codeforces rating problems 1400-1800 will increase the time complexity as well as how much will it effect on the space complexity ?

    • @Raj-yr3vz
      @Raj-yr3vz ปีที่แล้ว

      its applicable for dsa not cp

  • @nikhilreddydev
    @nikhilreddydev 2 ปีที่แล้ว +1

    How to balance between code speed and code quality?

  • @mcraven281
    @mcraven281 2 ปีที่แล้ว +2

    Definitely we need code reviews part 2 and also would like tutorial Or learning resources for SOLID principles @Striver

  • @swayam50
    @swayam50 2 ปีที่แล้ว +1

    Thank you so much Bhaiya for reviewing my code, I'll surely keep these tips in mind next time ❤️❤️.

  • @codingstation7741
    @codingstation7741 2 ปีที่แล้ว +1

    variable naming which one to prefer? Snake case or Camel Case?

  • @HariKrishna-wm8xn
    @HariKrishna-wm8xn 2 ปีที่แล้ว

    Can You suggest where can i start my coding journey...I have basic knowledge in Python ....Zero knowledge in DSA....Please reply

  • @arijitdey8419
    @arijitdey8419 2 ปีที่แล้ว +1

    Striver op!!! Definitely want a second video on this....

  • @vikramkumarsoni5283
    @vikramkumarsoni5283 2 ปีที่แล้ว

    Bhaiya whatever questions u teach are all optimised codes ?

  • @matrixtoogood5601
    @matrixtoogood5601 2 ปีที่แล้ว +2

    Second episode please! Thank you for this awesome video :)

  • @VishalKumar-hh4fw
    @VishalKumar-hh4fw 2 ปีที่แล้ว +3

    Very helpful video and something important has been taught in this.
    thank you, Bhai !!!

  • @evergreen7781
    @evergreen7781 2 ปีที่แล้ว +3

    The ideal Senior for any engineering college guy ❤️

  • @kunalsabadra6802
    @kunalsabadra6802 2 ปีที่แล้ว

    where is second episode

  • @thelegend5248
    @thelegend5248 2 ปีที่แล้ว +1

    @striver this is again in C++ not in java!! 😭

  • @uttamrawat7989
    @uttamrawat7989 ปีที่แล้ว

    at 6:21 you are saying maybe functional programming

  • @jolly_dollyyy
    @jolly_dollyyy 2 ปีที่แล้ว +2

    Yes second episode please!!!

  • @alokesh985
    @alokesh985 2 ปีที่แล้ว +1

    Please do more videos on code quality. Loved this.

  • @suhailf5014
    @suhailf5014 2 ปีที่แล้ว +1

    Many thanks for this!
    we need more such videos please :)

  • @pervejmia8240
    @pervejmia8240 2 ปีที่แล้ว

    How to improve communication skill?

  • @xskrish
    @xskrish 2 ปีที่แล้ว +1

    this is priceless man, thank you!

  • @naman_goyal
    @naman_goyal 2 ปีที่แล้ว +1

    Yes waiting for 2nd video with same topic

  • @arjunreddy8947
    @arjunreddy8947 2 ปีที่แล้ว

    Need 2nd part to this video. Please do it if possible.

  • @-RohitJaiswal
    @-RohitJaiswal 2 ปีที่แล้ว

    Please bring the 2nd episode 🎉🎉

  • @sanakamal5533
    @sanakamal5533 ปีที่แล้ว

    As the matter of fact, writing code like this also reduces chance of typos and logical errors.

  • @srikrishna6595
    @srikrishna6595 2 ปีที่แล้ว

    Plz make a playlist on oops... Bro

  • @mehlamali4773
    @mehlamali4773 2 ปีที่แล้ว

    Code Review more videos much Needed Sir !!

  • @yashikagupta3963
    @yashikagupta3963 2 ปีที่แล้ว

    Who else is giving such useful tips Literally No one but ONLY you 💯
    Unique & Amazing Content !!!!

  • @Live-hh6li
    @Live-hh6li 2 ปีที่แล้ว

    This is a great video
    Want second part

  • @harshittiwari4456
    @harshittiwari4456 2 ปีที่แล้ว +1

    Bhaiya Some java code review also plz.....

  • @AtulSingh-od1sx
    @AtulSingh-od1sx 2 ปีที่แล้ว

    Single responsibility principal?

  • @abhishekanantharam645
    @abhishekanantharam645 2 ปีที่แล้ว

    Useful!

  • @syednadiya69
    @syednadiya69 2 ปีที่แล้ว +1

    Code quality Episode 2🙋🏻‍♀️

  • @AbhishekVerma-qo5vu
    @AbhishekVerma-qo5vu 2 ปีที่แล้ว

    Need next video from your side about code quality.

  • @chirag7694
    @chirag7694 2 ปีที่แล้ว

    Thanks a lot for the video

  • @saileshramesh8113
    @saileshramesh8113 2 ปีที่แล้ว

    Please add part 2 striver.

  • @mr.anderson5077
    @mr.anderson5077 2 ปีที่แล้ว

    Please make a second edition for code quality video

  • @akshitgupta4749
    @akshitgupta4749 2 ปีที่แล้ว

    good to see u back again

  • @prakhargupta4320
    @prakhargupta4320 ปีที่แล้ว

    it must be really hurtful to see someone disecting your code like that 🥺

  • @aakashgarg8352
    @aakashgarg8352 2 ปีที่แล้ว

    Thankyou bhaiya. 2nd part please

  • @debugagrawal
    @debugagrawal 2 ปีที่แล้ว +3

    I'm feeling like a senior developer now.

  • @pavanrai6196
    @pavanrai6196 2 ปีที่แล้ว

    Please bring more code quality videos 🙂

  • @saiteja750
    @saiteja750 2 ปีที่แล้ว

    Please make more of these videos

  • @koushik1261
    @koushik1261 2 ปีที่แล้ว

    Usage of comments is also important?

  • @deepakjoshi4318
    @deepakjoshi4318 2 ปีที่แล้ว +1

    Java code bhi review krlete ekdo

  • @jayeshbhanushali1745
    @jayeshbhanushali1745 2 ปีที่แล้ว

    Yes i want next part

  • @finster156
    @finster156 2 ปีที่แล้ว

    CODE QUALITY 2nd episode much needed...

  • @himanshubanerji8800
    @himanshubanerji8800 ปีที่แล้ว

    please we need a second episode of code review

  • @shubiie
    @shubiie 2 ปีที่แล้ว

    want more videos on code review .

  • @sayankarmakar13
    @sayankarmakar13 2 ปีที่แล้ว

    Thanks a lot bhaiya 💕👏🏻

  • @anveshasharma2726
    @anveshasharma2726 2 ปีที่แล้ว

    bhaiya need 2nd part too

  • @vodnalasricharan1323
    @vodnalasricharan1323 2 ปีที่แล้ว

    Second Episode please

  • @gopendumanna9600
    @gopendumanna9600 2 ปีที่แล้ว

    Please dada do some more videos on code quality review 🙏

  • @marvel438
    @marvel438 2 ปีที่แล้ว

    Too good

  • @mohit9634
    @mohit9634 2 ปีที่แล้ว

    💛💛

  • @bharathkalyans
    @bharathkalyans 2 ปีที่แล้ว

    Loved it but you didn't review mine bhaiyya 🥺😭

  • @sounaksaha1455
    @sounaksaha1455 2 ปีที่แล้ว +2

    1st view

  • @pragneshamadavadi2267
    @pragneshamadavadi2267 2 ปีที่แล้ว

    op 🔥🔥🔥🔥🔥

  • @arjunmangali2904
    @arjunmangali2904 2 ปีที่แล้ว

    Need part 2 bhayya

  • @surajdangi6492
    @surajdangi6492 2 ปีที่แล้ว

    Striver op❤️

  • @sagarghare9829
    @sagarghare9829 ปีที่แล้ว

    Nice video bhaiya. please 2nd video please :)

  • @techwithlord
    @techwithlord 2 ปีที่แล้ว

    second part plzzzzzzzzzzzzz

  • @shreeramparija7731
    @shreeramparija7731 2 ปีที่แล้ว

    You look like Munawar Faruqui

  • @kaustubh9605
    @kaustubh9605 2 ปีที่แล้ว

    You're joining Google. Please like it if you really are.

  • @PrinceSharma-jg2mh
    @PrinceSharma-jg2mh 2 ปีที่แล้ว

    first

  • @shashankpathak7084
    @shashankpathak7084 2 ปีที่แล้ว

    .size() is actually O(1)