Looks GREAT To Me: Getting Past Bare Minimum Code Reviews

Ah code reviews. We need them, but we dread them. We do them, but not well. How do we deal with gigantic PRs? Why can't we write effective code review comments? How do we make code reviews shorter? Is SSDaaRB (Single Senior Developer as a Reviewer Bottleneck) something we just have to accept?
In this talk, I'll not only answer these questions, but give you actionable advice on how to improve your code review today!
I want to tell you:
- All the things you're doing wrong in your code review, both as an author and as a reviewer
- How to fix all those wrong things
- What we can do to make code reviews WAY better
Let's change the way we do code reviews. Let's do better than LGTM 👍 -- let's make the code review processes on our teams great!
-About the Speaker
Adrienne Braganza Tacke
Adrienne is a Filipina software engineer, international speaker, author of Coding for Kids: Python, and a LinkedIn Learning instructor...essentially, an overachiever. She's currently writing "Looks Good To Me: Constructive Code Reviews", a labor of love that she hopes will improve code reviews everywhere. Most importantly, she spends way too much money on coffee, desserts, and vintage clothing and ungodly amounts of time playing Age of Empires II.
adrienne.io/#t...
/ adriennetacke
/ adriennetacke
-
Links
dotnetsheff.co.uk
www.meetup.com...
x.com/dotnetsheff
-
The Video
Recorded by Adam Bright (x.com/adam_lx)
Mixed by Kevin Smith (x.com/kev_bite)
-
dotnetsheff
dotnetsheff is a monthly user group focused on software development, particularly in the .NET ecosystem. We welcome people with interests in software development of all ages and levels of experience

[@HugoTrentesaux]

**praise:** Thanks. It's helpful to put words on things we encounter when reviewing code.

[@mabainter]

In my contexts for code reviews LGTM has always been "Let's Get This Merged". I would be curious to know how widespread using it as "looks good to me" is, and whether that is a language community thing, an industry thing, generational thing or what...

[@actually_it_is_rocket_science]

I've never seen let's get this merged.... I've always heard it as "looks good to me". Yours is defo more manager friendly like saying rtfm means "read the friendly manual"

[@rudzik8164]

I've always read LGTM as LeGiTiMate in my head. when your project has at least somewhat strict code/PR guidelines, that actually starts making a lot of sense

[@johngagon]

If code reviews were done scientifically, they would be double blind. That there eliminates some of the bias problems with LGTM / UrKodSux types of reviews. Also, you should be liberal with kudos.
Very interesting takes. Thank you for covering this topic. It's much neglected in terms of meta/looking outside the box on this topic. I esp like how to be more specific on the code itself, suggest what it is you are looking for instead of just making a gripe.