Wonderful overview of what a good pull request is! Using copilot to perform an initial code review from a security perspective also seems like such a good practice I could see someone baking this as a pre-commit hook if that doesn’t exist already - brilliant video
Great post! Minor feedback ... Consistent formatting was not ensured in this demo PR; there should be empty line breaks after if- and for- blocks consistently. Just pointing it out because inconsistent code formatting bothers me like nothing else :D
Thanks Bassem, very informative, high quality, and straight to the point 👍Keep it up!
Wonderful overview of what a good pull request is! Using copilot to perform an initial code review from a security perspective also seems like such a good practice I could see someone baking this as a pre-commit hook if that doesn’t exist already - brilliant video
🙌🙌
Great video, I am waiting to see your video about Kubernetes Operator
Yes, I’m excited to start working on it too
Great post! Minor feedback ...
Consistent formatting was not ensured in this demo PR; there should be empty line breaks after if- and for- blocks consistently.
Just pointing it out because inconsistent code formatting bothers me like nothing else :D
Haha, I agree! Thank you Copilot 😅 I should have the linter running on file save for future demos
جميل يا باسم ❤
حبيبي يا احمد، شكراً🙏❤️
Biggest fault in these PRs is not using Dark Mode 😎
I use light mode for accessibility :) I use dark mode almost exclusively