"Looks Good to Me" Constructive Code Reviews • Adrienne Braganza Tacke & Paul Slaughter • GOTO 2024

แชร์
ฝัง
  • เผยแพร่เมื่อ 4 ม.ค. 2025

ความคิดเห็น • 9

  • @GOTO-
    @GOTO-  หลายเดือนก่อน

    Looking for books & other references mentioned in this video?
    Check out the video description for all the links!
    Want early access to videos & exclusive perks?
    Join our channel membership today: th-cam.com/channels/s_tLP3AiwYKwdUHpltJPuA.htmljoin
    Question for you: What’s your biggest takeaway from this video? Let us know in the comments! ⬇

  • @bewilderedlearningevolving
    @bewilderedlearningevolving 2 หลายเดือนก่อน +14

    I learned so much, looking forward to reading, and thank you. I also appreciate the presentation of the related talks throughout, as well as including the links in the description. Well done!

    • @adriennebraganzatacke
      @adriennebraganzatacke 2 หลายเดือนก่อน +5

      @@bewilderedlearningevolving Happy to hear that! Thank you 🫶🏼

  • @nathantoups
    @nathantoups 2 หลายเดือนก่อน +3

    Adrienne is so cool. Her book is great.

    • @adriennebraganzatacke
      @adriennebraganzatacke 2 หลายเดือนก่อน

      Nathan is also cool. His (and Carter's) podcast @BookOverflowPod is amazing!

  • @Ravi_Mohan
    @Ravi_Mohan 2 หลายเดือนก่อน +5

    Would love to read this book. One question which I keep thinking about is what is the right time for the code review. Currently mostly it seems to happen at the end of the coding process. You as the developer think you are done. Then you get a bunch of feedback which if you take up, feels like you have wasted a lot of time. So the question is do we need lots of intermediate reviews rather than a big one in the end?

    • @souldzin
      @souldzin 2 หลายเดือนก่อน +1

      @Ravi_Mohan this is a great question. At GitLab, we try to encourage "as soon as there is code to review, get a review".
      We'll call this an "early review" and it's a *GREAT* time saver in the long run. We've had so many MR's involve stakeholders too late and be forced to completely shift their approach which could have been prevented if they involved maintainers earlier in the process.
      In @adriennebraganzatacke's book she dives into establishing Code Review objectives/goals through collaboratively establishing a Team-Working-Agreement document. I think "when/how do we handle early reviews" is a great topic that an organization should discuss.

  • @aslkdjfzxcv9779
    @aslkdjfzxcv9779 2 หลายเดือนก่อน

    if i reviewed for efficacy id never get anything else done. 🤣

  • @JovelynLazo-y6c
    @JovelynLazo-y6c 2 หลายเดือนก่อน

    😮❤❤😊😊😊😊😊😊😊wr